From: Richard Cochran <richardcochran@gmail.com>
To: Felipe Balbi <felipe.balbi@linux.intel.com>
Cc: Christopher S Hall <christopher.s.hall@intel.com>,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3 1/2] PTP: introduce new versions of IOCTLs
Date: Tue, 10 Sep 2019 08:44:52 -0700 [thread overview]
Message-ID: <20190910154452.GB4016@localhost> (raw)
In-Reply-To: <20190909075940.12843-1-felipe.balbi@linux.intel.com>
On Mon, Sep 09, 2019 at 10:59:39AM +0300, Felipe Balbi wrote:
> case PTP_PEROUT_REQUEST:
> + case PTP_PEROUT_REQUEST2:
...
> + if (((req.perout.flags & ~PTP_PEROUT_VALID_FLAGS) ||
> + req.perout.rsv[0] || req.perout.rsv[1] ||
> + req.perout.rsv[2] || req.perout.rsv[3]) &&
> + cmd == PTP_PEROUT_REQUEST2) {
> + err = -EINVAL;
> + break;
...
> +/*
> + * Bits of the ptp_perout_request.flags field:
> + */
> +#define PTP_PEROUT_VALID_FLAGS (~0)
I think you meant (0) here, or I am confused...
Thanks,
Richard
next prev parent reply other threads:[~2019-09-10 15:45 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-09-09 7:59 [PATCH v3 1/2] PTP: introduce new versions of IOCTLs Felipe Balbi
2019-09-09 7:59 ` [PATCH v3 2/2] PTP: add support for one-shot output Felipe Balbi
2019-09-10 15:47 ` Richard Cochran
2019-09-10 15:44 ` Richard Cochran [this message]
2019-09-11 6:08 ` [PATCH v3 1/2] PTP: introduce new versions of IOCTLs Felipe Balbi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190910154452.GB4016@localhost \
--to=richardcochran@gmail.com \
--cc=christopher.s.hall@intel.com \
--cc=felipe.balbi@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).