From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.0 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id ED814ECDE27 for ; Wed, 11 Sep 2019 08:13:26 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id CD88C21D79 for ; Wed, 11 Sep 2019 08:13:26 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727165AbfIKINX (ORCPT ); Wed, 11 Sep 2019 04:13:23 -0400 Received: from shards.monkeyblade.net ([23.128.96.9]:39916 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726735AbfIKINX (ORCPT ); Wed, 11 Sep 2019 04:13:23 -0400 Received: from localhost (unknown [148.69.85.38]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (Client did not present a certificate) (Authenticated sender: davem-davemloft) by shards.monkeyblade.net (Postfix) with ESMTPSA id 15CD615565B7D; Wed, 11 Sep 2019 01:13:21 -0700 (PDT) Date: Wed, 11 Sep 2019 10:13:20 +0200 (CEST) Message-Id: <20190911.101320.682967997452798874.davem@davemloft.net> To: navid.emamdoost@gmail.com Cc: emamd001@umn.edu, smccaman@umn.edu, kjlu@umn.edu, netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] net: qrtr: fix memort leak in qrtr_tun_write_iter From: David Miller In-Reply-To: <20190911003748.26841-1-navid.emamdoost@gmail.com> References: <20190911003748.26841-1-navid.emamdoost@gmail.com> X-Mailer: Mew version 6.8 on Emacs 26.2 Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Wed, 11 Sep 2019 01:13:23 -0700 (PDT) Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org From: Navid Emamdoost Date: Tue, 10 Sep 2019 19:37:45 -0500 > In qrtr_tun_write_iter the allocated kbuf should be release in case of > error happening. > > Signed-off-by: Navid Emamdoost Shouldn't it also be freed in case of success too?