From: David Miller <davem@davemloft.net>
To: jeffrey.t.kirsher@intel.com
Cc: alexander.h.duyck@linux.intel.com, netdev@vger.kernel.org,
nhorman@redhat.com, sassmann@redhat.com,
gleventhal@janestreet.com, andrewx.bowers@intel.com
Subject: Re: [net-next 11/14] ixgbe: Prevent u8 wrapping of ITR value to something less than 10us
Date: Wed, 11 Sep 2019 10:24:02 +0200 (CEST) [thread overview]
Message-ID: <20190911.102402.1190991958573233070.davem@davemloft.net> (raw)
In-Reply-To: <20190910163434.2449-12-jeffrey.t.kirsher@intel.com>
From: Jeff Kirsher <jeffrey.t.kirsher@intel.com>
Date: Tue, 10 Sep 2019 09:34:31 -0700
> From: Alexander Duyck <alexander.h.duyck@linux.intel.com>
>
> There were a couple cases where the ITR value generated via the adaptive
> ITR scheme could exceed 126. This resulted in the value becoming either 0
> or something less than 10. Switching back and forth between a value less
> than 10 and a value greater than 10 can cause issues as certain hardware
> features such as RSC to not function well when the ITR value has dropped
> that low.
>
> Reported-by: Gregg Leventhal <gleventhal@janestreet.com>
> Signed-off-by: Alexander Duyck <alexander.h.duyck@linux.intel.com>
> Tested-by: Andrew Bowers <andrewx.bowers@intel.com>
> Signed-off-by: Jeff Kirsher <jeffrey.t.kirsher@intel.com>
Please remove this from the series, add the Fixes: tag, and submit for 'net'
since Alexander says it is -stable material.
Thanks.
next prev parent reply other threads:[~2019-09-11 8:24 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-09-10 16:34 [net-next 00/14][pull request] Intel Wired LAN Driver Updates 2019-09-10 Jeff Kirsher
2019-09-10 16:34 ` [net-next 01/14] ixgbe: fix memory leaks Jeff Kirsher
2019-09-10 16:34 ` [net-next 02/14] i40e: check __I40E_VF_DISABLE bit in i40e_sync_filters_subtask Jeff Kirsher
2019-09-10 16:34 ` [net-next 03/14] ixgbe: use skb_get_queue_mapping in tx path Jeff Kirsher
2019-09-10 16:34 ` [net-next 04/14] i40e: use ktime_get_real_ts64 instead of ktime_to_timespec64 Jeff Kirsher
2019-09-10 16:34 ` [net-next 05/14] i40e: remove I40E_AQC_ADD_CLOUD_FILTER_OIP Jeff Kirsher
2019-09-10 16:34 ` [net-next 06/14] i40e: mark additional missing bits as reserved Jeff Kirsher
2019-09-10 16:34 ` [net-next 07/14] i40e: fix missed "Negotiated" string in i40e_print_link_message() Jeff Kirsher
2019-09-10 16:34 ` [net-next 08/14] i40e: Fix message for other card without FEC Jeff Kirsher
2019-09-10 16:34 ` [net-next 09/14] i40e: use BIT macro to specify the cloud filter field flags Jeff Kirsher
2019-09-10 16:34 ` [net-next 10/14] i40e: clear __I40E_VIRTCHNL_OP_PENDING on invalid min Tx rate Jeff Kirsher
2019-09-10 16:34 ` [net-next 11/14] ixgbe: Prevent u8 wrapping of ITR value to something less than 10us Jeff Kirsher
2019-09-10 22:19 ` Alexander Duyck
2019-09-11 8:24 ` David Miller [this message]
2019-09-10 16:34 ` [net-next 12/14] iavf: fix MAC address setting for VFs when filter is rejected Jeff Kirsher
2019-09-10 16:34 ` [net-next 13/14] net/ixgbevf: make array api static const, makes object smaller Jeff Kirsher
2019-09-10 16:34 ` [net-next 14/14] i40e: fix potential RX buffer starvation for AF_XDP Jeff Kirsher
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190911.102402.1190991958573233070.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=alexander.h.duyck@linux.intel.com \
--cc=andrewx.bowers@intel.com \
--cc=gleventhal@janestreet.com \
--cc=jeffrey.t.kirsher@intel.com \
--cc=netdev@vger.kernel.org \
--cc=nhorman@redhat.com \
--cc=sassmann@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox