From: Thomas Higdon <tph@fb.com>
To: "netdev@vger.kernel.org" <netdev@vger.kernel.org>
Cc: Jonathan Lemon <jonathan.lemon@gmail.com>,
Dave Jones <dsj@fb.com>, "Eric Dumazet" <edumazet@google.com>,
Neal Cardwell <ncardwell@google.com>
Subject: [PATCH v3 2/2] tcp: Add rcv_wnd to TCP_INFO
Date: Wed, 11 Sep 2019 22:31:52 +0000 [thread overview]
Message-ID: <20190911223148.89808-2-tph@fb.com> (raw)
In-Reply-To: <20190911223148.89808-1-tph@fb.com>
Neal Cardwell mentioned that rcv_wnd would be useful for helping
diagnose whether a flow is receive-window-limited at a given instant.
This serves the purpose of adding an additional __u32 to avoid the
would-be hole caused by the addition of the tcpi_rcvi_ooopack field.
Signed-off-by: Thomas Higdon <tph@fb.com>
---
include/uapi/linux/tcp.h | 1 +
net/ipv4/tcp.c | 1 +
2 files changed, 2 insertions(+)
diff --git a/include/uapi/linux/tcp.h b/include/uapi/linux/tcp.h
index 20237987ccc8..8a0d1d1af622 100644
--- a/include/uapi/linux/tcp.h
+++ b/include/uapi/linux/tcp.h
@@ -272,6 +272,7 @@ struct tcp_info {
__u32 tcpi_reord_seen; /* reordering events seen */
__u32 tcpi_rcv_ooopack; /* Out-of-order packets received */
+ __u32 tcpi_rcv_wnd; /* Receive window size */
};
/* netlink attributes types for SCM_TIMESTAMPING_OPT_STATS */
diff --git a/net/ipv4/tcp.c b/net/ipv4/tcp.c
index 4cf58208270e..c980145c4247 100644
--- a/net/ipv4/tcp.c
+++ b/net/ipv4/tcp.c
@@ -3297,6 +3297,7 @@ void tcp_get_info(struct sock *sk, struct tcp_info *info)
info->tcpi_dsack_dups = tp->dsack_dups;
info->tcpi_reord_seen = tp->reord_seen;
info->tcpi_rcv_ooopack = tp->rcv_ooopack;
+ info->tcpi_rcv_wnd = tp->rcv_wnd;
unlock_sock_fast(sk, slow);
}
EXPORT_SYMBOL_GPL(tcp_get_info);
--
2.17.1
next prev parent reply other threads:[~2019-09-11 22:32 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-09-11 22:31 [PATCH v3 1/2] tcp: Add TCP_INFO counter for packets received out-of-order Thomas Higdon
2019-09-11 22:31 ` Thomas Higdon [this message]
2019-09-12 0:49 ` [PATCH v3 2/2] tcp: Add rcv_wnd to TCP_INFO Neal Cardwell
2019-09-12 9:14 ` Dave Taht
2019-09-13 14:29 ` Thomas Higdon
2019-09-13 14:37 ` Neal Cardwell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190911223148.89808-2-tph@fb.com \
--to=tph@fb.com \
--cc=dsj@fb.com \
--cc=edumazet@google.com \
--cc=jonathan.lemon@gmail.com \
--cc=ncardwell@google.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).