From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.0 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2E412C49ED6 for ; Wed, 11 Sep 2019 23:01:35 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 0753E20838 for ; Wed, 11 Sep 2019 23:01:34 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728569AbfIKXBe (ORCPT ); Wed, 11 Sep 2019 19:01:34 -0400 Received: from shards.monkeyblade.net ([23.128.96.9]:49982 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726761AbfIKXBd (ORCPT ); Wed, 11 Sep 2019 19:01:33 -0400 Received: from localhost (unknown [88.214.186.163]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (Client did not present a certificate) (Authenticated sender: davem-davemloft) by shards.monkeyblade.net (Postfix) with ESMTPSA id 5397E154FCEF8; Wed, 11 Sep 2019 16:01:32 -0700 (PDT) Date: Thu, 12 Sep 2019 01:01:30 +0200 (CEST) Message-Id: <20190912.010130.736236657631199212.davem@davemloft.net> To: simon.horman@netronome.com Cc: jakub.kicinski@netronome.com, netdev@vger.kernel.org, oss-drivers@netronome.com, dirk.vandermerwe@netronome.com Subject: Re: [PATCH net-next] nfp: read chip model from the PluDevice register From: David Miller In-Reply-To: <20190911152118.30698-1-simon.horman@netronome.com> References: <20190911152118.30698-1-simon.horman@netronome.com> X-Mailer: Mew version 6.8 on Emacs 26.2 Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Wed, 11 Sep 2019 16:01:33 -0700 (PDT) Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org From: Simon Horman Date: Wed, 11 Sep 2019 16:21:18 +0100 > From: Dirk van der Merwe > > The PluDevice register provides the authoritative chip model/revision. > > Since the model number is purely used for reporting purposes, follow > the hardware team convention of subtracting 0x10 from the PluDevice > register to obtain the chip model/revision number. > > Suggested-by: Francois H. Theron > Signed-off-by: Dirk van der Merwe > Signed-off-by: Simon Horman Applied.