From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.8 required=3.0 tests=DKIM_ADSP_CUSTOM_MED, DKIM_INVALID,DKIM_SIGNED,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 448C1C4CEC7 for ; Fri, 13 Sep 2019 04:23:56 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 1DAB6208C2 for ; Fri, 13 Sep 2019 04:23:56 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="GUvypkao" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726620AbfIMEXx (ORCPT ); Fri, 13 Sep 2019 00:23:53 -0400 Received: from mail-io1-f68.google.com ([209.85.166.68]:45946 "EHLO mail-io1-f68.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725385AbfIMEXw (ORCPT ); Fri, 13 Sep 2019 00:23:52 -0400 Received: by mail-io1-f68.google.com with SMTP id f12so60098265iog.12; Thu, 12 Sep 2019 21:23:52 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id; bh=77SoApYkFt3isyCsrY6dkIW1UAAJ7m+Z3V3KK6V4A70=; b=GUvypkaofnmPrAjAlwJgfb58Ko6ovCWLN6QjacOFu3EVClbgTUSWhpCXaM5EcVFzAg BErq8qd7bkhjY7mTPChVqjsDmtC4PB6jxnIkSlhK2JwaNp8AeMjcecEFYCKNzsmRfud5 ZylbApopgg3GlcmVF9BgvrSreKyfzHH/QAq2QGFL606b0m47uWEws44Efu9LRchvT3BJ TRq4Xrc3glOHgp0hm+F+7bhr68Js8K23WgpOrK3VenDovjcv/2VZZhTmT6H4TAbYNo6z uevqos7dR0m/q7LZMf06b6vjkC7uHESAh25zI5Z6DVr6qgZe9COXBlfeOIOmRgI9l0Wr HCJQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=77SoApYkFt3isyCsrY6dkIW1UAAJ7m+Z3V3KK6V4A70=; b=RzV+eoeXQmqNBYmaN9LDEGIWtN0CRbXVnzQlfdDUYrRdSys5huH3ff7eocR4rGQJjN k8I6fWyDvGAvTiI8Da+iuoIqpCqw2ygQwAEALJRCCrJBo+lJcXDV7cotY9uy0AFnmAgi 34iIn71Dh3iHaA8OSkodTQ7/i3HyrMYSBg3yzMSfQvAsJE3d7hZ544djxcv1j75zjPa2 3pgUVVr9zRQGYA2Mqa6mg5bA/cgpkhdyppPnY6ThEs/vc1/s5lADjeRN+sV0cLk2xrPz YravDqjAMvfqMy8W30r5jUaFveUGpr2i/yJhUFZgxWYMcSJvzq4iUstr/+zHVR0iSnot VM7Q== X-Gm-Message-State: APjAAAUUBlEKkOqOvs4gB+SqDExo7PuiXZ3GAXCkj53ia4+/H4O9yMx6 szmeLZ3ykEzsuGeuM2Ubxng= X-Google-Smtp-Source: APXvYqyjtqbjM8GW5BGGtDVrVHCMFNfYy9E21J1r8qxh2yoZM0mKIHECdUHQjAqJo77wkoR4we5xOA== X-Received: by 2002:a5d:91c8:: with SMTP id k8mr9465769ior.232.1568348631660; Thu, 12 Sep 2019 21:23:51 -0700 (PDT) Received: from cs-dulles.cs.umn.edu (cs-dulles.cs.umn.edu. [128.101.35.54]) by smtp.googlemail.com with ESMTPSA id z11sm23474759ioi.88.2019.09.12.21.23.50 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 12 Sep 2019 21:23:50 -0700 (PDT) From: Navid Emamdoost Cc: emamd001@umn.edu, smccaman@umn.edu, kjlu@umn.edu, Navid Emamdoost , Johannes Berg , Emmanuel Grumbach , Luca Coelho , Intel Linux Wireless , Kalle Valo , "David S. Miller" , Shahar S Matityahu , Sara Sharon , linux-wireless@vger.kernel.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH] iwlwifi: dbg_ini: fix memory leak in alloc_sgtable Date: Thu, 12 Sep 2019 23:23:27 -0500 Message-Id: <20190913042331.27080-1-navid.emamdoost@gmail.com> X-Mailer: git-send-email 2.17.1 To: unlisted-recipients:; (no To-header on input) Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org In alloc_sgtable if alloc_page fails, the alocated table should be released. Signed-off-by: Navid Emamdoost --- drivers/net/wireless/intel/iwlwifi/fw/dbg.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/net/wireless/intel/iwlwifi/fw/dbg.c b/drivers/net/wireless/intel/iwlwifi/fw/dbg.c index 4d81776f576d..db41abb3361d 100644 --- a/drivers/net/wireless/intel/iwlwifi/fw/dbg.c +++ b/drivers/net/wireless/intel/iwlwifi/fw/dbg.c @@ -643,6 +643,7 @@ static struct scatterlist *alloc_sgtable(int size) if (new_page) __free_page(new_page); } + kfree(table); return NULL; } alloc_size = min_t(int, size, PAGE_SIZE); -- 2.17.1