From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.8 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,URIBL_SBL,URIBL_SBL_A,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C8BC9C49ED7 for ; Fri, 13 Sep 2019 08:21:25 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 80F9F207FC for ; Fri, 13 Sep 2019 08:21:25 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=resnulli-us.20150623.gappssmtp.com header.i=@resnulli-us.20150623.gappssmtp.com header.b="TsFAShQF" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2387453AbfIMIVY (ORCPT ); Fri, 13 Sep 2019 04:21:24 -0400 Received: from mail-wr1-f52.google.com ([209.85.221.52]:41259 "EHLO mail-wr1-f52.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2387435AbfIMIVY (ORCPT ); Fri, 13 Sep 2019 04:21:24 -0400 Received: by mail-wr1-f52.google.com with SMTP id h7so30132489wrw.8 for ; Fri, 13 Sep 2019 01:21:22 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=resnulli-us.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=IT3lbS0nlgM/zpV4Tjq1wwmFa4Su9XjodZJMOCVhN1g=; b=TsFAShQFjcvPJtAvVaMvpPLyBvXiQ+AnTA3YsH0mDGmOuHqakog4N2iCZE7ltf54QR 2mvV+E5wiNwyTp2e87frZLtQZoyJxapg9hylO6U80+T0c6cg+SolL6x1PYIx84sFLjVC KjyQtW5pDVPyYF9XHOwoxl229Wwk0eI67Xq1Z3rAD74L2RT5eml6MGettrb1S//WnTxC fEO8InXnl7gty7F2I8u5C92jifTA7pOtjWzCyk+NorcoCixJ6d2SWDbP4vJZj3UpkWaE Ke4b+eubiO0OQg4H56paayAobF7Xo1tuNRtmP1Mb/6Cku2CyV0oyexSND/RInVUrgGHi Epcw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=IT3lbS0nlgM/zpV4Tjq1wwmFa4Su9XjodZJMOCVhN1g=; b=uYhIOyCF9QBOlKdbAvZxZwmKn+c/+lnjwiFF9S29BykkwttRAp5NXtAteHG7YtJ8Qz hsVPp2+FeN71mhweYcMhpWjnvK8Ds+KenwFcFfLzB74ozh9+E1stCuuVGFz7mB+USN9D Jdwug7drRJL3Y5cKHLpU8Cs/gTyHsNWxG4CL9uKVQIRzYaCsTkcaK+RCAWOW5eSqqKT4 F+lTlfI8mlbMpWVNl7A8lhcQpUmxuuKP4Sb5Rf5rHRVzjTuw2+BLN5FJOsw0AgYMaask ikFNlo8256IAp4UWX5XwSMaIDV3C8Xb1YLNySSjpoIIWmwJMMgOt06XvrkthsuRKZXvC cd8w== X-Gm-Message-State: APjAAAV8T2kh5MvlUnDqaLWJ4SGPp+LAD/4NcKEjqwxbH9qqpf9ZjuZo 1OWamcocKjEtBWLKJWe1T5GjFw== X-Google-Smtp-Source: APXvYqyOGIBwelqwA0dJT84XTdHl9/5HBkBlURDaSTjKGWmcLrs8S+D0EulQabA+ur3LuLKOkAOjsQ== X-Received: by 2002:adf:ef05:: with SMTP id e5mr7282184wro.127.1568362882374; Fri, 13 Sep 2019 01:21:22 -0700 (PDT) Received: from localhost (ip-213-220-255-83.net.upcbroadband.cz. [213.220.255.83]) by smtp.gmail.com with ESMTPSA id x5sm38310626wrg.69.2019.09.13.01.21.21 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 13 Sep 2019 01:21:21 -0700 (PDT) Date: Fri, 13 Sep 2019 10:21:21 +0200 From: Jiri Pirko To: Roopa Prabhu Cc: Michal Kubecek , netdev , David Miller , Jakub Kicinski , David Ahern , Stephen Hemminger , dcbw@redhat.com, Andrew Lunn , parav@mellanox.com, Saeed Mahameed , mlxsw Subject: Re: [patch net-next rfc 3/7] net: rtnetlink: add commands to add and delete alternative ifnames Message-ID: <20190913082121.GD2330@nanopsycho> References: <20190827070808.GA2250@nanopsycho> <20190827.012242.418276717667374306.davem@davemloft.net> <20190827093525.GB2250@nanopsycho> <20190828070711.GE2312@nanopsycho> <20190829052620.GK29594@unicorn.suse.cz> <20190830170342.GR2312@nanopsycho> <20190912115942.GC7621@nanopsycho.orion> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190912115942.GC7621@nanopsycho.orion> User-Agent: Mutt/1.11.4 (2019-03-13) Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org Thu, Sep 12, 2019 at 01:59:42PM CEST, jiri@resnulli.us wrote: >Fri, Aug 30, 2019 at 07:03:42PM CEST, jiri@resnulli.us wrote: >>Fri, Aug 30, 2019 at 04:35:23PM CEST, roopa@cumulusnetworks.com wrote: > >[...] > >>> >>>so to summarize, i think we have discussed the following options to >>>update a netlink list attribute so far: >>>(a) encode an optional attribute/flag in the list attribute in >>>RTM_SETLINK to indicate if it is a add or del If we do this, how do you imagine this is going to be used from cmdline? ip link set ? How exactly? Thanks! >>>(b) Use a flag in RTM_SETLINK and RTM_DELINK to indicate add/del >>>(close to bridge vlan add/del) >> >>Nope, bridge vlan add/del is done according to the cmd, not any flag. >> >> >>>(c) introduce a separate generic msg type to add/del to a list >>>attribute (IIUC this does need a separate msg type per subsystem or >>>netlink API) > >Getting back to this, sorry. > >Thinking about it for some time, a,b,c have all their issues. Why can't >we have another separate cmd as I originally proposed in this RFC? Does >anyone have any argument against it? Could you please describe? > >Because otherwise, I don't feel comfortable going to any of a,b,c :( > >Thanks! >