From: Francois Romieu <romieu@fr.zoreil.com>
To: Dan Carpenter <dan.carpenter@oracle.com>
Cc: "David S. Miller" <davem@davemloft.net>,
netdev@vger.kernel.org, kernel-janitors@vger.kernel.org
Subject: Re: [PATCH] net/wan: dscc4: remove broken dscc4 driver
Date: Mon, 16 Sep 2019 01:06:40 +0200 [thread overview]
Message-ID: <20190915230640.GA7382@electric-eye.fr.zoreil.com> (raw)
In-Reply-To: <20190913132817.GA13179@mwanda>
Dan Carpenter <dan.carpenter@oracle.com> :
> Using static analysis, I discovered that the "dpriv->pci_priv->pdev"
> pointer is always NULL. This pointer was supposed to be initialized
> during probe and is essential for the driver to work. It would be easy
> to add a "ppriv->pdev = pdev;" to dscc4_found1() but this driver has
> been broken since before we started using git and no one has complained
> so probably we should just remove it.
>
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Acked-by: Francois Romieu <romieu@fr.zoreil.com>
--
Ueimor
next prev parent reply other threads:[~2019-09-15 23:12 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-09-13 13:28 [PATCH] net/wan: dscc4: remove broken dscc4 driver Dan Carpenter
2019-09-15 23:06 ` Francois Romieu [this message]
2019-09-16 7:15 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190915230640.GA7382@electric-eye.fr.zoreil.com \
--to=romieu@fr.zoreil.com \
--cc=dan.carpenter@oracle.com \
--cc=davem@davemloft.net \
--cc=kernel-janitors@vger.kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).