From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.5 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id EB7D3C4CEC4 for ; Sun, 15 Sep 2019 23:12:17 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id BF8F420692 for ; Sun, 15 Sep 2019 23:12:17 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728684AbfIOXMR (ORCPT ); Sun, 15 Sep 2019 19:12:17 -0400 Received: from violet.fr.zoreil.com ([92.243.8.30]:45552 "EHLO violet.fr.zoreil.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728438AbfIOXMQ (ORCPT ); Sun, 15 Sep 2019 19:12:16 -0400 X-Greylist: delayed 325 seconds by postgrey-1.27 at vger.kernel.org; Sun, 15 Sep 2019 19:12:15 EDT Received: from violet.fr.zoreil.com (localhost [127.0.0.1]) by violet.fr.zoreil.com (8.14.9/8.14.9) with ESMTP id x8FN6fx3007397; Mon, 16 Sep 2019 01:06:41 +0200 Received: (from romieu@localhost) by violet.fr.zoreil.com (8.14.9/8.14.5/Submit) id x8FN6e0i007396; Mon, 16 Sep 2019 01:06:40 +0200 Date: Mon, 16 Sep 2019 01:06:40 +0200 From: Francois Romieu To: Dan Carpenter Cc: "David S. Miller" , netdev@vger.kernel.org, kernel-janitors@vger.kernel.org Subject: Re: [PATCH] net/wan: dscc4: remove broken dscc4 driver Message-ID: <20190915230640.GA7382@electric-eye.fr.zoreil.com> References: <20190913132817.GA13179@mwanda> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190913132817.GA13179@mwanda> X-Organisation: Land of Sunshine Inc. User-Agent: Mutt/1.5.23 (2014-03-12) Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org Dan Carpenter : > Using static analysis, I discovered that the "dpriv->pci_priv->pdev" > pointer is always NULL. This pointer was supposed to be initialized > during probe and is essential for the driver to work. It would be easy > to add a "ppriv->pdev = pdev;" to dscc4_found1() but this driver has > been broken since before we started using git and no one has complained > so probably we should just remove it. > > Signed-off-by: Dan Carpenter Acked-by: Francois Romieu -- Ueimor