From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 591F1C49ED7 for ; Mon, 16 Sep 2019 07:09:08 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 30C722067D for ; Mon, 16 Sep 2019 07:09:08 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730395AbfIPHJH (ORCPT ); Mon, 16 Sep 2019 03:09:07 -0400 Received: from shards.monkeyblade.net ([23.128.96.9]:44296 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727126AbfIPHJH (ORCPT ); Mon, 16 Sep 2019 03:09:07 -0400 Received: from localhost (unknown [85.119.46.8]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (Client did not present a certificate) (Authenticated sender: davem-davemloft) by shards.monkeyblade.net (Postfix) with ESMTPSA id ECE3F15163F1A; Mon, 16 Sep 2019 00:09:05 -0700 (PDT) Date: Mon, 16 Sep 2019 09:09:04 +0200 (CEST) Message-Id: <20190916.090904.1028775758249846734.davem@davemloft.net> To: lucien.xin@gmail.com Cc: netdev@vger.kernel.org, u9012063@gmail.com Subject: Re: [PATCH net] ip6_gre: fix a dst leak in ip6erspan_tunnel_xmit From: David Miller In-Reply-To: <1bfbf329c5b3649a6c6362350a0d609ff184deba.1568367947.git.lucien.xin@gmail.com> References: <1bfbf329c5b3649a6c6362350a0d609ff184deba.1568367947.git.lucien.xin@gmail.com> X-Mailer: Mew version 6.8 on Emacs 26.2 Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Mon, 16 Sep 2019 00:09:06 -0700 (PDT) Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org From: Xin Long Date: Fri, 13 Sep 2019 17:45:47 +0800 > In ip6erspan_tunnel_xmit(), if the skb will not be sent out, it has to > be freed on the tx_err path. Otherwise when deleting a netns, it would > cause dst/dev to leak, and dmesg shows: > > unregister_netdevice: waiting for lo to become free. Usage count = 1 > > Fixes: ef7baf5e083c ("ip6_gre: add ip6 erspan collect_md mode") > Signed-off-by: Xin Long Applied and queued up for -stable.