From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 50A62C49ED7 for ; Mon, 16 Sep 2019 07:15:35 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 2851D2067D for ; Mon, 16 Sep 2019 07:15:35 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729732AbfIPHPe (ORCPT ); Mon, 16 Sep 2019 03:15:34 -0400 Received: from shards.monkeyblade.net ([23.128.96.9]:44402 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726667AbfIPHPe (ORCPT ); Mon, 16 Sep 2019 03:15:34 -0400 Received: from localhost (unknown [85.119.46.8]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (Client did not present a certificate) (Authenticated sender: davem-davemloft) by shards.monkeyblade.net (Postfix) with ESMTPSA id 8F82715163DC1; Mon, 16 Sep 2019 00:15:32 -0700 (PDT) Date: Mon, 16 Sep 2019 09:15:31 +0200 (CEST) Message-Id: <20190916.091531.804053772243575655.davem@davemloft.net> To: dan.carpenter@oracle.com Cc: romieu@fr.zoreil.com, netdev@vger.kernel.org, kernel-janitors@vger.kernel.org Subject: Re: [PATCH] net/wan: dscc4: remove broken dscc4 driver From: David Miller In-Reply-To: <20190913132817.GA13179@mwanda> References: <20190913132817.GA13179@mwanda> X-Mailer: Mew version 6.8 on Emacs 26.2 Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Mon, 16 Sep 2019 00:15:33 -0700 (PDT) Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org From: Dan Carpenter Date: Fri, 13 Sep 2019 16:28:17 +0300 > Using static analysis, I discovered that the "dpriv->pci_priv->pdev" > pointer is always NULL. This pointer was supposed to be initialized > during probe and is essential for the driver to work. It would be easy > to add a "ppriv->pdev = pdev;" to dscc4_found1() but this driver has > been broken since before we started using git and no one has complained > so probably we should just remove it. > > Signed-off-by: Dan Carpenter Applied to net-next.