From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.4 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3028CC4CECD for ; Mon, 16 Sep 2019 22:04:21 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id ED586206C2 for ; Mon, 16 Sep 2019 22:04:20 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="hv59pXfy" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1732771AbfIPWEU (ORCPT ); Mon, 16 Sep 2019 18:04:20 -0400 Received: from mail-lj1-f196.google.com ([209.85.208.196]:37342 "EHLO mail-lj1-f196.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1732642AbfIPWET (ORCPT ); Mon, 16 Sep 2019 18:04:19 -0400 Received: by mail-lj1-f196.google.com with SMTP id c22so1441196ljj.4 for ; Mon, 16 Sep 2019 15:04:16 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:mail-followup-to:references :mime-version:content-disposition:in-reply-to:user-agent; bh=an8Tg0keAdSMZgI1pA83USwohPIWdfUkBfCw/Vxa0hM=; b=hv59pXfy2WeDYAVOITvOqi5pmbivkfyJEmrsWkFDXA2OijgH8E4ceqm8i61GPbaYML yt9Rep1apYmMxAzvW1DoX+b7veawQc/j2oFXjXkwmVjtq07PKyGqvuH2mWXFLHqRti9e 3eVbV5UIW5nxPj0SkRdCrVl2+wMPJBwBCFaat2EQkV5GKKP1LErG3HPgMzKFhCufxgMo 2ZMu/4tuqbmWyu4sz+HCEKd15qrvE87rZ2rb6G+DdjFRte8KPenKCtqx4OF4GLUb0HR9 f7YPCEv9ct/lZBQmB0Cotn4PpnNpMpvzZP8gqAoVU0npRdfwXqHau30dIoce7ygjSc0r G6IQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id :mail-followup-to:references:mime-version:content-disposition :in-reply-to:user-agent; bh=an8Tg0keAdSMZgI1pA83USwohPIWdfUkBfCw/Vxa0hM=; b=Ljo8GjmTrlA+c/byUtEnEWRwrd/vTG+5ltmbWA0SzPoFLSAD6lCJ81tjIcn4fKf74J kZEtD//GiPnR9Qjj/PHDCAmpo/JgA2NztFNmgeHkMzpbWVYEfhRttc4pUrddN5Wi2i/X 8jEHhE3fb7NQz92LlvKVGmutteU/gcQLFOQo7SznpBYjSlBwvNKbCLLAUw1HsKUQMgCy DheHsG4bttOZm4XYbEVeLG8TYM7MDvYj7Lulq3STDWVIEX2O5tBps4tftDNzVdD/rqPt +vZcGmXY7W4EspFBsCOGcAnCkWthnwpcHxX42jMDlIuvt7/yAH+szBiqejfYp1oYLF5K HZNw== X-Gm-Message-State: APjAAAWufzqc+gfJauoagOiZMIbvqn09Kd5rtr0gcz1/nTdaKcgfENJI 2pFqmFY0DvaBmDJG47z6Yd5qMg== X-Google-Smtp-Source: APXvYqxKcpaUkIgEEiF9cNrbe9aM6QbWJZh2LRNWuc6kfhQ6aLuq3JgpMsPLd/oxBkW+nYaCZTr3hw== X-Received: by 2002:a2e:958c:: with SMTP id w12mr67916ljh.98.1568671455527; Mon, 16 Sep 2019 15:04:15 -0700 (PDT) Received: from khorivan (168-200-94-178.pool.ukrtel.net. [178.94.200.168]) by smtp.gmail.com with ESMTPSA id e8sm40562ljk.54.2019.09.16.15.04.14 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Mon, 16 Sep 2019 15:04:14 -0700 (PDT) Date: Tue, 17 Sep 2019 01:04:12 +0300 From: Ivan Khoronzhuk To: Andrii Nakryiko Cc: Alexei Starovoitov , Daniel Borkmann , Yonghong Song , "David S. Miller" , Jakub Kicinski , Jesper Dangaard Brouer , john fastabend , open list , Networking , bpf , clang-built-linux@googlegroups.com, sergei.shtylyov@cogentembedded.com Subject: Re: [PATCH v3 bpf-next 05/14] samples: bpf: makefile: use __LINUX_ARM_ARCH__ selector for arm Message-ID: <20190916220411.GC4420@khorivan> Mail-Followup-To: Andrii Nakryiko , Alexei Starovoitov , Daniel Borkmann , Yonghong Song , "David S. Miller" , Jakub Kicinski , Jesper Dangaard Brouer , john fastabend , open list , Networking , bpf , clang-built-linux@googlegroups.com, sergei.shtylyov@cogentembedded.com References: <20190916105433.11404-1-ivan.khoronzhuk@linaro.org> <20190916105433.11404-6-ivan.khoronzhuk@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii; format=flowed Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.9.4 (2018-02-28) Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Mon, Sep 16, 2019 at 01:44:23PM -0700, Andrii Nakryiko wrote: >On Mon, Sep 16, 2019 at 3:59 AM Ivan Khoronzhuk > wrote: >> >> For arm, -D__LINUX_ARM_ARCH__=X is min version used as instruction >> set selector and is absolutely required while parsing some parts of >> headers. It's present in KBUILD_CFLAGS but not in autoconf.h, so let's >> retrieve it from and add to programs cflags. In another case errors >> like "SMP is not supported" for armv7 and bunch of other errors are >> issued resulting to incorrect final object. >> --- >> samples/bpf/Makefile | 10 ++++++++++ >> 1 file changed, 10 insertions(+) >> >> diff --git a/samples/bpf/Makefile b/samples/bpf/Makefile >> index 8ecc5d0c2d5b..d3c8db3df560 100644 >> --- a/samples/bpf/Makefile >> +++ b/samples/bpf/Makefile >> @@ -185,6 +185,16 @@ HOSTLDLIBS_map_perf_test += -lrt >> HOSTLDLIBS_test_overhead += -lrt >> HOSTLDLIBS_xdpsock += -pthread >> >> +ifeq ($(ARCH), arm) >> +# Strip all except -D__LINUX_ARM_ARCH__ option needed to handle linux >> +# headers when arm instruction set identification is requested. >> +ARM_ARCH_SELECTOR = $(shell echo "$(KBUILD_CFLAGS) " | \ >> + sed 's/[[:blank:]]/\n/g' | sed '/^-D__LINUX_ARM_ARCH__/!d') > >Does the following work exactly like that without shelling out (and >being arguably simpler)? > >ARM_ARCH_SELECTOR = $(filter -D__LINUX_ARM_ARCH__%, $(KBUILD_CFLAGS)) > >> + >> +CLANG_EXTRA_CFLAGS := $(ARM_ARCH_SELECTOR) >> +KBUILD_HOSTCFLAGS := $(ARM_ARCH_SELECTOR) > >Isn't this clearing out previous value of KBUILD_HOSTCFLAGS? Is that >intentional, or it was supposed to be += here? > >> +endif >> + >> # Allows pointing LLC/CLANG to a LLVM backend with bpf support, redefine on cmdline: >> # make samples/bpf/ LLC=~/git/llvm/build/bin/llc CLANG=~/git/llvm/build/bin/clang >> LLC ?= llc >> -- >> 2.17.1 >> Just left from previous version filtering all -D options. Will update in next v., SELECTOR also. -- Regards, Ivan Khoronzhuk