From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.3 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 83EBFC4CEC9 for ; Tue, 17 Sep 2019 12:40:23 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 5B5A521881 for ; Tue, 17 Sep 2019 12:40:23 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728112AbfIQMkW (ORCPT ); Tue, 17 Sep 2019 08:40:22 -0400 Received: from mx1.redhat.com ([209.132.183.28]:52220 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727776AbfIQMkW (ORCPT ); Tue, 17 Sep 2019 08:40:22 -0400 Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.phx2.redhat.com [10.5.11.16]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id E0B501056FB1; Tue, 17 Sep 2019 12:40:21 +0000 (UTC) Received: from bistromath.localdomain (ovpn-116-43.ams2.redhat.com [10.36.116.43]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 12B0D5C21E; Tue, 17 Sep 2019 12:40:20 +0000 (UTC) Date: Tue, 17 Sep 2019 14:40:19 +0200 From: Sabrina Dubroca To: Steffen Klassert Cc: netdev@vger.kernel.org, Herbert Xu Subject: Re: [PATCH ipsec-next v2 6/6] xfrm: add espintcp (RFC 8229) Message-ID: <20190917124019.GA91878@bistromath.localdomain> References: <20190917112649.GE2879@gauss3.secunet.de> <20190917115743.GA89567@bistromath.localdomain> <20190917120413.GF2879@gauss3.secunet.de> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20190917120413.GF2879@gauss3.secunet.de> User-Agent: Mutt/1.12.1 (2019-06-15) X-Scanned-By: MIMEDefang 2.79 on 10.5.11.16 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.6.2 (mx1.redhat.com [10.5.110.64]); Tue, 17 Sep 2019 12:40:22 +0000 (UTC) Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org 2019-09-17, 14:04:13 +0200, Steffen Klassert wrote: > On Tue, Sep 17, 2019 at 01:57:43PM +0200, Sabrina Dubroca wrote: > > 2019-09-17, 13:26:49 +0200, Steffen Klassert wrote: > > > On Wed, Sep 11, 2019 at 04:13:07PM +0200, Sabrina Dubroca wrote: > > > ... > > > > diff --git a/net/xfrm/Kconfig b/net/xfrm/Kconfig > > > > index 51bb6018f3bf..e67044527fb7 100644 > > > > --- a/net/xfrm/Kconfig > > > > +++ b/net/xfrm/Kconfig > > > > @@ -73,6 +73,16 @@ config XFRM_IPCOMP > > > > select CRYPTO > > > > select CRYPTO_DEFLATE > > > > > > > > +config XFRM_ESPINTCP > > > > + bool "ESP in TCP encapsulation (RFC 8229)" > > > > + depends on XFRM && INET_ESP > > > > + select STREAM_PARSER > > > > + select NET_SOCK_MSG > > > > + help > > > > + Support for RFC 8229 encapsulation of ESP and IKE over TCP sockets. > > > > + > > > > + If unsure, say N. > > > > + > > > > > > One nitpick: This is IPv4 only, so please move this below the ESP > > > section in net/ipv4/Kconfig and use the naming convention there. > > > I.e. bool "IP: ESP in TCP encapsulation (RFC 8229)" > > > > That's temporary, though, the next step will be to make it work for > > both IPv4 and IPv6. Do you prefer I move it to net/ipv4/Kconfig for > > now, and then back to net/xfrm/Kconfig when I add IPv6 support? > > We have separate config options for ESP4 and ESP6, so we should > also have separate config options for 'ESP in TCP' for IPv4 and IPv6. > So this should go to net/ipv4/Kconfig. When you add IPv6 support > place it in net/ipv6/Kconfig. Ok, I'll do that, and rename the config entry to CONFIG_INET_ESPINTCP. Thanks. -- Sabrina