From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.6 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id F347AC4CECE for ; Tue, 17 Sep 2019 14:03:46 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id C9DC42171F for ; Tue, 17 Sep 2019 14:03:46 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="key not found in DNS" (0-bit key) header.d=codeaurora.org header.i=@codeaurora.org header.b="lHZdxjg2"; dkim=fail reason="key not found in DNS" (0-bit key) header.d=codeaurora.org header.i=@codeaurora.org header.b="jeJJCXHi" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726559AbfIQODo (ORCPT ); Tue, 17 Sep 2019 10:03:44 -0400 Received: from smtp.codeaurora.org ([198.145.29.96]:45750 "EHLO smtp.codeaurora.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726467AbfIQODo (ORCPT ); Tue, 17 Sep 2019 10:03:44 -0400 Received: by smtp.codeaurora.org (Postfix, from userid 1000) id D11AF61576; Tue, 17 Sep 2019 14:03:41 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=codeaurora.org; s=default; t=1568729023; bh=z5NkcZ1ALVg0VMSVQaQZtgQ5NF7xi3wRIZFmstI/iR0=; h=Subject:From:In-Reply-To:References:To:Cc:Date:From; b=lHZdxjg2FqLYr6alImg+/DyYa6PRazOBXVd/8JUhbltu+hxDRZIDzy/L5XXjqo97I ehmzC1bvtwQkd6m6qlTre41CXB2Fa87HR+abQI40+FYNnQMnMUp1ROdsAtqcBnH+Ye uEoHvOjy5PO5xAHcDNrJm38qrDsYnLb/3yHzVIEA= Received: from potku.adurom.net (88-114-240-156.elisa-laajakaista.fi [88.114.240.156]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) (Authenticated sender: kvalo@smtp.codeaurora.org) by smtp.codeaurora.org (Postfix) with ESMTPSA id 1075061544; Tue, 17 Sep 2019 14:03:37 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=codeaurora.org; s=default; t=1568729020; bh=z5NkcZ1ALVg0VMSVQaQZtgQ5NF7xi3wRIZFmstI/iR0=; h=Subject:From:In-Reply-To:References:To:Cc:From; b=jeJJCXHihlrr3GhJk2NSJZIDcKcDp/aKDu/n/iGSyjRoQBvdz5fOMU5maZZ+Muqdd jwWtd3qtswR3UwRjeSWJaFTM/inXnIsU5ssyiVPHpn3dFcIOi8BBaROieQMr4fPxi6 qlI1rSaOgDVs04aGiRmipWdauCiGkPTHZsIYggC8= DMARC-Filter: OpenDMARC Filter v1.3.2 smtp.codeaurora.org 1075061544 Authentication-Results: pdx-caf-mail.web.codeaurora.org; dmarc=none (p=none dis=none) header.from=codeaurora.org Authentication-Results: pdx-caf-mail.web.codeaurora.org; spf=none smtp.mailfrom=kvalo@codeaurora.org Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Subject: Re: [PATCH] ath10k: Fix HOST capability QMI incompatibility From: Kalle Valo In-Reply-To: <20190725063108.15790-1-bjorn.andersson@linaro.org> References: <20190725063108.15790-1-bjorn.andersson@linaro.org> To: Bjorn Andersson Cc: "David S. Miller" , Rob Herring , Mark Rutland , linux-wireless@vger.kernel.org, netdev@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, ath10k@lists.infradead.org, stable@vger.kernel.org User-Agent: pwcli/0.0.0-git (https://github.com/kvalo/pwcli/) Python/2.7.12 Message-Id: <20190917140342.D11AF61576@smtp.codeaurora.org> Date: Tue, 17 Sep 2019 14:03:41 +0000 (UTC) Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org Bjorn Andersson wrote: > The introduction of 768ec4c012ac ("ath10k: update HOST capability QMI > message") served the purpose of supporting the new and extended HOST > capability QMI message. > > But while the new message adds a slew of optional members it changes the > data type of the "daemon_support" member, which means that older > versions of the firmware will fail to decode the incoming request > message. > > There is no way to detect this breakage from Linux and there's no way to > recover from sending the wrong message (i.e. we can't just try one > format and then fallback to the other), so a quirk is introduced in > DeviceTree to indicate to the driver that the firmware requires the 8bit > version of this message. > > Cc: stable@vger.kernel.org > Fixes: 768ec4c012ac ("ath10k: update HOST capability qmi message") > Signed-off-by: Bjorn Andersson > Acked-by: Rob Herring > Signed-off-by: Kalle Valo Patch applied to ath-next branch of ath.git, thanks. 7165ef890a4c ath10k: Fix HOST capability QMI incompatibility -- https://patchwork.kernel.org/patch/11058005/ https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches