netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Steffen Klassert <steffen.klassert@secunet.com>
To: <netdev@vger.kernel.org>
Cc: Steffen Klassert <steffen.klassert@secunet.com>,
	Willem de Bruijn <willemb@google.com>,
	Paolo Abeni <pabeni@redhat.com>
Subject: [PATCH RFC v3 0/5] Support fraglist GRO/GSO
Date: Wed, 18 Sep 2019 09:25:12 +0200	[thread overview]
Message-ID: <20190918072517.16037-1-steffen.klassert@secunet.com> (raw)

This patchset adds support to do GRO/GSO by chaining packets
of the same flow at the SKB frag_list pointer. This avoids
the overhead to merge payloads into one big packet, and
on the other end, if GSO is needed it avoids the overhead
of splitting the big packet back to the native form.

Patch 1 Enables UDP GRO by default.

Patch 2 adds a netdev feature flag to enable listifyed GRO,
this implements one of the configuration options discussed
at netconf 2019.

Patch 3 adds a netdev software feature set that defaults to off
and assigns the new listifyed GRO feature flag to it.

Patch 4 adds the core infrastructure to do fraglist GRO/GSO.

Patch 5 enables UDP to use fraglist GRO/GSO if configured and no
GRO supported socket is found.

I have only meaningful forwarding performance measurements.
I did some tests for the local receive path with netperf and iperf,
but in this case the sender that generates the packets is the
bottleneck. So the benchmarks are not that meaningful for the
receive path.

Paolo Abeni did some benchmarks of the local receive path for the v2
version of this pachset, results can be found here:

https://www.spinics.net/lists/netdev/msg551158.html

I used my IPsec forwarding test setup for the performance measurements:

           ------------         ------------
        -->| router 1 |-------->| router 2 |--
        |  ------------         ------------  |
        |                                     |
        |       --------------------          |
        --------|Spirent Testcenter|<----------
                --------------------

net-next (September 7th):

Single stream UDP frame size 1460 Bytes: 1.161.000 fps (13.5 Gbps).

----------------------------------------------------------------------

net-next (September 7th) + standard UDP GRO/GSO:

Single stream UDP frame size 1460 Bytes: 1.801.000 fps (21 Gbps).

----------------------------------------------------------------------

net-next (September 7th) + fraglist UDP GRO/GSO:

Single stream UDP frame size 1460 Bytes: 2.860.000 fps (33.4 Gbps).

-----------------------------------------------------------------------

Changes from v1:

- Add IPv6 support.
- Split patchset to enable UDP GRO by default before adding
  fraglist GRO support.
- Mark fraglist GRO packets as CHECKSUM_NONE.
- Take a refcount on the first segment skb when doing fraglist
  segmentation. With this we can use the same error handling
  path as with standard segmentation.

Changes from v2:

- Add a netdev feature flag to configure listifyed GRO.
- Fix UDP GRO enabling for IPv6.
- Fix a rcu_read_lock() imbalance.
- Fix error path in skb_segment_list().

             reply	other threads:[~2019-09-18  7:25 UTC|newest]

Thread overview: 25+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-09-18  7:25 Steffen Klassert [this message]
2019-09-18  7:25 ` [PATCH RFC v3 1/5] UDP: enable GRO by default Steffen Klassert
2019-09-18  7:25 ` [PATCH RFC v3 2/5] net: Add NETIF_F_GRO_LIST feature Steffen Klassert
2019-09-18 16:10   ` Willem de Bruijn
2019-09-19  2:04     ` Subash Abhinov Kasiviswanathan
2019-09-19  9:32       ` Steffen Klassert
2019-09-19  9:24     ` Steffen Klassert
2019-09-18  7:25 ` [PATCH RFC v3 3/5] net: Add a netdev software feature set that defaults to off Steffen Klassert
2019-09-18  7:25 ` [PATCH RFC v3 4/5] net: Support GRO/GSO fraglist chaining Steffen Klassert
2019-09-18  7:25 ` [PATCH RFC v3 5/5] udp: Support UDP fraglist GRO/GSO Steffen Klassert
2019-09-18 16:13   ` Willem de Bruijn
2019-09-19  9:33     ` Steffen Klassert
2019-09-18 16:17 ` [PATCH RFC v3 0/5] Support " Willem de Bruijn
2019-09-18 16:58   ` Marcelo Ricardo Leitner
2019-09-18 19:31     ` Subash Abhinov Kasiviswanathan
2019-09-19 11:01     ` Steffen Klassert
2019-09-19 11:18       ` David Miller
2019-09-19 11:36         ` Steffen Klassert
2019-09-19 12:55     ` Willem de Bruijn
2019-09-19 13:07       ` Marcelo Ricardo Leitner
2019-09-19 13:25         ` Willem de Bruijn
2019-09-19  9:41   ` Steffen Klassert
2019-09-19 13:11     ` Marcelo Ricardo Leitner
2019-09-19 12:37 ` Or Gerlitz
2019-09-19 13:51   ` Paolo Abeni

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190918072517.16037-1-steffen.klassert@secunet.com \
    --to=steffen.klassert@secunet.com \
    --cc=netdev@vger.kernel.org \
    --cc=pabeni@redhat.com \
    --cc=willemb@google.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).