From: Steffen Klassert <steffen.klassert@secunet.com>
To: <netdev@vger.kernel.org>
Cc: Steffen Klassert <steffen.klassert@secunet.com>,
Willem de Bruijn <willemb@google.com>,
Paolo Abeni <pabeni@redhat.com>
Subject: [PATCH RFC v3 3/5] net: Add a netdev software feature set that defaults to off.
Date: Wed, 18 Sep 2019 09:25:15 +0200 [thread overview]
Message-ID: <20190918072517.16037-4-steffen.klassert@secunet.com> (raw)
In-Reply-To: <20190918072517.16037-1-steffen.klassert@secunet.com>
The previous patch added the NETIF_F_GRO_LIST feature.
This is a software feature that should default to off.
Current software features default to on, so add a new
feature set that defaults to off.
Signed-off-by: Steffen Klassert <steffen.klassert@secunet.com>
---
include/linux/netdev_features.h | 3 +++
net/core/dev.c | 2 +-
2 files changed, 4 insertions(+), 1 deletion(-)
diff --git a/include/linux/netdev_features.h b/include/linux/netdev_features.h
index 1b6baa1b6fe9..e8b3c943d835 100644
--- a/include/linux/netdev_features.h
+++ b/include/linux/netdev_features.h
@@ -228,6 +228,9 @@ static inline int find_next_netdev_feature(u64 feature, unsigned long start)
/* changeable features with no special hardware requirements */
#define NETIF_F_SOFT_FEATURES (NETIF_F_GSO | NETIF_F_GRO)
+/* Changeable features with no special hardware requirements that defaults to off. */
+#define NETIF_F_SOFT_FEATURES_OFF NETIF_F_GRO_LIST
+
#define NETIF_F_VLAN_FEATURES (NETIF_F_HW_VLAN_CTAG_FILTER | \
NETIF_F_HW_VLAN_CTAG_RX | \
NETIF_F_HW_VLAN_CTAG_TX | \
diff --git a/net/core/dev.c b/net/core/dev.c
index b1afafee3e2a..cc0bbec0f1d7 100644
--- a/net/core/dev.c
+++ b/net/core/dev.c
@@ -8730,7 +8730,7 @@ int register_netdevice(struct net_device *dev)
/* Transfer changeable features to wanted_features and enable
* software offloads (GSO and GRO).
*/
- dev->hw_features |= NETIF_F_SOFT_FEATURES;
+ dev->hw_features |= (NETIF_F_SOFT_FEATURES | NETIF_F_SOFT_FEATURES_OFF);
dev->features |= NETIF_F_SOFT_FEATURES;
if (dev->netdev_ops->ndo_udp_tunnel_add) {
--
2.17.1
next prev parent reply other threads:[~2019-09-18 7:25 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-09-18 7:25 [PATCH RFC v3 0/5] Support fraglist GRO/GSO Steffen Klassert
2019-09-18 7:25 ` [PATCH RFC v3 1/5] UDP: enable GRO by default Steffen Klassert
2019-09-18 7:25 ` [PATCH RFC v3 2/5] net: Add NETIF_F_GRO_LIST feature Steffen Klassert
2019-09-18 16:10 ` Willem de Bruijn
2019-09-19 2:04 ` Subash Abhinov Kasiviswanathan
2019-09-19 9:32 ` Steffen Klassert
2019-09-19 9:24 ` Steffen Klassert
2019-09-18 7:25 ` Steffen Klassert [this message]
2019-09-18 7:25 ` [PATCH RFC v3 4/5] net: Support GRO/GSO fraglist chaining Steffen Klassert
2019-09-18 7:25 ` [PATCH RFC v3 5/5] udp: Support UDP fraglist GRO/GSO Steffen Klassert
2019-09-18 16:13 ` Willem de Bruijn
2019-09-19 9:33 ` Steffen Klassert
2019-09-18 16:17 ` [PATCH RFC v3 0/5] Support " Willem de Bruijn
2019-09-18 16:58 ` Marcelo Ricardo Leitner
2019-09-18 19:31 ` Subash Abhinov Kasiviswanathan
2019-09-19 11:01 ` Steffen Klassert
2019-09-19 11:18 ` David Miller
2019-09-19 11:36 ` Steffen Klassert
2019-09-19 12:55 ` Willem de Bruijn
2019-09-19 13:07 ` Marcelo Ricardo Leitner
2019-09-19 13:25 ` Willem de Bruijn
2019-09-19 9:41 ` Steffen Klassert
2019-09-19 13:11 ` Marcelo Ricardo Leitner
2019-09-19 12:37 ` Or Gerlitz
2019-09-19 13:51 ` Paolo Abeni
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190918072517.16037-4-steffen.klassert@secunet.com \
--to=steffen.klassert@secunet.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=willemb@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).