From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.1 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7E4DDC4CEC4 for ; Thu, 19 Sep 2019 02:50:20 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 46659214AF for ; Thu, 19 Sep 2019 02:50:20 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=lunn.ch header.i=@lunn.ch header.b="h7ij+hoc" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2388437AbfISCuT (ORCPT ); Wed, 18 Sep 2019 22:50:19 -0400 Received: from vps0.lunn.ch ([185.16.172.187]:54132 "EHLO vps0.lunn.ch" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727324AbfISCuT (ORCPT ); Wed, 18 Sep 2019 22:50:19 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lunn.ch; s=20171124; h=In-Reply-To:Content-Type:MIME-Version:References:Message-ID: Subject:Cc:To:From:Date:Sender:Reply-To:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=SOt6fitAuRZcRmpDfmMRTm1rrq+84NUpxW5B9Ow0huo=; b=h7ij+hoc0z+F4jZxXJuvQ0tiAg 2DM/0nV7LmfjIhAmGXpmOemVUGudE2gfkcAr2UQP3uDQH6ou4Fv7NY2rzLnoxgRE7CdN0D5cvkahH ScJXFJYRI733pFEYIwjTJHMPaPDu00tAUx7CmubXtx1NfgUEgFRd1HCP6uZA0IpxcT9Y=; Received: from andrew by vps0.lunn.ch with local (Exim 4.89) (envelope-from ) id 1iAmWO-0003QV-RE; Thu, 19 Sep 2019 04:50:16 +0200 Date: Thu, 19 Sep 2019 04:50:16 +0200 From: Andrew Lunn To: Peter Mamonov Cc: f.fainelli@gmail.com, hkallweit1@gmail.com, netdev@vger.kernel.org Subject: Re: [PATCH RFC] net/phy: fix Marvell PHYs probe failure when HWMON and THERMAL_OF are enabled Message-ID: <20190919025016.GA12785@lunn.ch> References: <20190918213837.24585-1-pmamonov@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190918213837.24585-1-pmamonov@gmail.com> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Thu, Sep 19, 2019 at 12:38:37AM +0300, Peter Mamonov wrote: > Hello, > > Some time ago I've discovered that probe functions of certain Marvell PHYs > fail if both HWMON and THERMAL_OF config options are enabled. Hi Peter It probably affects more then Marvell PHYs. > The root > cause of this problem is a lack of an OF node for a PHY's built-in > temperature sensor. However I consider adding this OF node to be a bit > excessive solution. Am I wrong? Below you will find a one line patch which > fixes the problem. Your patch look sensible to me. > I've sent it to the releveant maintainers three weeks > ago without any feedback yet. Could you point me at the relevant mailing list archive? Thanks Andrew