From: Jakub Kicinski <jakub.kicinski@netronome.com>
To: Nathan Chancellor <natechancellor@gmail.com>
Cc: Shannon Nelson <snelson@pensando.io>,
Pensando Drivers <drivers@pensando.io>,
"David S. Miller" <davem@davemloft.net>,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
clang-built-linux@googlegroups.com,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Subject: Re: [PATCH] ionic: Remove unnecessary ternary operator in ionic_debugfs_add_ident
Date: Thu, 19 Sep 2019 17:21:36 -0700 [thread overview]
Message-ID: <20190919172136.01f0e016@cakuba.netronome.com> (raw)
In-Reply-To: <20190917232616.125261-1-natechancellor@gmail.com>
On Tue, 17 Sep 2019 16:26:16 -0700, Nathan Chancellor wrote:
> clang warns:
>
> ../drivers/net/ethernet/pensando/ionic/ionic_debugfs.c:60:37: warning:
> expression result unused [-Wunused-value]
> ionic, &identity_fops) ? 0 : -EOPNOTSUPP;
> ^~~~~~~~~~~
> 1 warning generated.
>
> The return value of debugfs_create_file does not need to be checked [1]
> and the function returns void so get rid of the ternary operator, it is
> unnecessary.
>
> [1]: https://lore.kernel.org/linux-mm/20150815160730.GB25186@kroah.com/
>
> Fixes: fbfb8031533c ("ionic: Add hardware init and device commands")
> Link: https://github.com/ClangBuiltLinux/linux/issues/658
> Signed-off-by: Nathan Chancellor <natechancellor@gmail.com>
Applied, thank you!
prev parent reply other threads:[~2019-09-20 0:21 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-09-17 23:26 [PATCH] ionic: Remove unnecessary ternary operator in ionic_debugfs_add_ident Nathan Chancellor
2019-09-17 23:40 ` Shannon Nelson
2019-09-18 5:57 ` Greg Kroah-Hartman
2019-09-20 0:21 ` Jakub Kicinski [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190919172136.01f0e016@cakuba.netronome.com \
--to=jakub.kicinski@netronome.com \
--cc=clang-built-linux@googlegroups.com \
--cc=davem@davemloft.net \
--cc=drivers@pensando.io \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=natechancellor@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=snelson@pensando.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox