From: Jakub Kicinski <jakub.kicinski@netronome.com>
To: Murilo Fossa Vicentini <muvic@linux.ibm.com>
Cc: netdev@vger.kernel.org, tlfalcon@linux.ibm.com, muvic@br.ibm.com,
abdhalee@linux.vnet.ibm.com
Subject: Re: [PATCH net] ibmvnic: Warn unknown speed message only when carrier is present
Date: Thu, 19 Sep 2019 17:37:57 -0700 [thread overview]
Message-ID: <20190919173757.0a6b1194@cakuba.netronome.com> (raw)
In-Reply-To: <20190916145037.77376-1-muvic@linux.ibm.com>
On Mon, 16 Sep 2019 11:50:37 -0300, Murilo Fossa Vicentini wrote:
> With commit 0655f9943df2 ("net/ibmvnic: Update carrier state after link
> state change") we are now able to detect when the carrier is properly
> present in the device, so only report an unexpected unknown speed when it
> is properly detected. Unknown speed is expected to be seen by the device
> in case the backing device has no link detected.
>
> Reported-by: Abdul Haleem <abdhalee@linux.vnet.ibm.com>
> Tested-by: Abdul Haleem <abdhalee@linux.vnet.ibm.com>
> Signed-off-by: Murilo Fossa Vicentini <muvic@linux.ibm.com>
Applied, thanks!
prev parent reply other threads:[~2019-09-20 0:38 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-09-16 14:50 [PATCH net] ibmvnic: Warn unknown speed message only when carrier is present Murilo Fossa Vicentini
2019-09-16 15:21 ` Thomas Falcon
2019-09-20 0:37 ` Jakub Kicinski [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190919173757.0a6b1194@cakuba.netronome.com \
--to=jakub.kicinski@netronome.com \
--cc=abdhalee@linux.vnet.ibm.com \
--cc=muvic@br.ibm.com \
--cc=muvic@linux.ibm.com \
--cc=netdev@vger.kernel.org \
--cc=tlfalcon@linux.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox