From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B5070C4CEC9 for ; Fri, 20 Sep 2019 18:52:27 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 8BB67208C0 for ; Fri, 20 Sep 2019 18:52:27 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=wp.pl header.i=@wp.pl header.b="s5ny6L1G" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2406276AbfITSwQ (ORCPT ); Fri, 20 Sep 2019 14:52:16 -0400 Received: from mx4.wp.pl ([212.77.101.12]:11818 "EHLO mx4.wp.pl" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2405644AbfITSwP (ORCPT ); Fri, 20 Sep 2019 14:52:15 -0400 X-Greylist: delayed 398 seconds by postgrey-1.27 at vger.kernel.org; Fri, 20 Sep 2019 14:52:14 EDT Received: (wp-smtpd smtp.wp.pl 15208 invoked from network); 20 Sep 2019 20:45:33 +0200 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=wp.pl; s=1024a; t=1569005134; bh=cizgm+wM/wjxUasVlGK7XAg12mZAPfOsYXg1d/8EQ90=; h=From:To:Cc:Subject; b=s5ny6L1GowL9XNrTar3fPEsX/ROiUgvN4PSEig0HQBPfKd+NPMYlml8HBaYwosXsM pIw+74PyBFdJfjgsNhteK+dKxq+FIgc9WlEwAa20eriPCWeZTbvRLK3SVfH3j1JGYO CeW+uDB4WLNOAsMJK7SYNkPTmOsnU36ogpr/QAxY= Received: from 014.152-60-66-biz-static.surewest.net (HELO cakuba.netronome.com) (kubakici@wp.pl@[66.60.152.14]) (envelope-sender ) by smtp.wp.pl (WP-SMTPD) with ECDHE-RSA-AES256-GCM-SHA384 encrypted SMTP for ; 20 Sep 2019 20:45:33 +0200 Date: Fri, 20 Sep 2019 11:45:15 -0700 From: Jakub Kicinski To: Lorenzo Bianconi Cc: Colin King , Kalle Valo , "David S . Miller" , Matthias Brugger , linux-wireless@vger.kernel.org, netdev@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org, kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] mt7601u: phy: simplify zero check on val Message-ID: <20190920114515.36e1ed90@cakuba.netronome.com> In-Reply-To: <20190920135817.GC6456@localhost.localdomain> References: <20190920125414.15507-1-colin.king@canonical.com> <20190920135817.GC6456@localhost.localdomain> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-WP-MailID: 624ef302b2416e660574dde2845ab35d X-WP-AV: skaner antywirusowy Poczty Wirtualnej Polski X-WP-SPAM: NO 000000A [AVOU] Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Fri, 20 Sep 2019 15:58:17 +0200, Lorenzo Bianconi wrote: > I think this is not correct since (not considering the cast) we should break > from the loop if val != 0 and val != 0xff, so the right approach I guess is: > > diff --git a/drivers/net/wireless/mediatek/mt7601u/phy.c b/drivers/net/wireless/mediatek/mt7601u/phy.c > index 06f5702ab4bd..d863ab4a66c9 100644 > --- a/drivers/net/wireless/mediatek/mt7601u/phy.c > +++ b/drivers/net/wireless/mediatek/mt7601u/phy.c > @@ -213,7 +213,7 @@ int mt7601u_wait_bbp_ready(struct mt7601u_dev *dev) > > do { > val = mt7601u_bbp_rr(dev, MT_BBP_REG_VERSION); > - if (val && ~val) > + if (val && val != 0xff) > break; > } while (--i); Yup, feel free to add my ack if you post this, Lorenzo.