From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id AA423C49ED7 for ; Fri, 20 Sep 2019 13:58:24 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 811922067B for ; Fri, 20 Sep 2019 13:58:24 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728796AbfITN6X (ORCPT ); Fri, 20 Sep 2019 09:58:23 -0400 Received: from mx1.redhat.com ([209.132.183.28]:54394 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727941AbfITN6X (ORCPT ); Fri, 20 Sep 2019 09:58:23 -0400 Received: from mail-wm1-f71.google.com (mail-wm1-f71.google.com [209.85.128.71]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id C294A87633 for ; Fri, 20 Sep 2019 13:58:22 +0000 (UTC) Received: by mail-wm1-f71.google.com with SMTP id h6so1268019wmb.2 for ; Fri, 20 Sep 2019 06:58:22 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=spCZuDFD0EPU5ozujvfnvvEa34kbUMxIApAez+Dggu8=; b=guqV5OUdFRkNBT38sq+6VXzHCb+98BljBPSkQNTGUCP/de7y0m+wrDRCerb1LCyVD2 Bw43iKBsX1G4jdWPkcTxs1Ayf8AGJQeLGIa43EhCPNoBhbhsYzBKNicold8LoZWRIW4h qj4JCLnwK5WB8cE+cuuwuMT/vSH+EGpMH1iGDXqwAR3AddLuIsMvVtkVB+tUf7YUXI+f O9/X1Hh84rP7NzNtvfH/6YWaDMhHF0BD/9BYS4NgSkVWobPH9nW0AAeuAJzZG3pcGoyO KzGx1WfKJc5Z3poWOe5hXjc04oj+nheA6/ILCqlkZHMJx43Q6E3EqaTL8xtoeACRvUwo fvwQ== X-Gm-Message-State: APjAAAW1DWyKOPyT/lNtyBg0dV5Pk+DTa4NpRyjUxkINjlLC+PbFojjY 11NgxKBpYUCA8BrgxguhePvrCmisQwPeLOwS7IFsQXtWnJVuavXbcpYnnpr7/jqshjAC5uFo9yc c1WjbKwBCxMMZ09tt X-Received: by 2002:a05:600c:241:: with SMTP id 1mr3641702wmj.162.1568987901451; Fri, 20 Sep 2019 06:58:21 -0700 (PDT) X-Google-Smtp-Source: APXvYqxaL42VK6Hbg90QmZTlVy0wuDzSPLddZwEiO+ZOepAYrKU0ro0hZ5/EONlchkImHxvmp3T81A== X-Received: by 2002:a05:600c:241:: with SMTP id 1mr3641679wmj.162.1568987901220; Fri, 20 Sep 2019 06:58:21 -0700 (PDT) Received: from localhost.localdomain (nat-pool-mxp-t.redhat.com. [149.6.153.186]) by smtp.gmail.com with ESMTPSA id r6sm1834884wmh.38.2019.09.20.06.58.19 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 20 Sep 2019 06:58:20 -0700 (PDT) Date: Fri, 20 Sep 2019 15:58:17 +0200 From: Lorenzo Bianconi To: Colin King Cc: Jakub Kicinski , Kalle Valo , "David S . Miller" , Matthias Brugger , linux-wireless@vger.kernel.org, netdev@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org, kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] mt7601u: phy: simplify zero check on val Message-ID: <20190920135817.GC6456@localhost.localdomain> References: <20190920125414.15507-1-colin.king@canonical.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="i7F3eY7HS/tUJxUd" Content-Disposition: inline In-Reply-To: <20190920125414.15507-1-colin.king@canonical.com> User-Agent: Mutt/1.12.1 (2019-06-15) Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org --i7F3eY7HS/tUJxUd Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable > From: Colin Ian King >=20 > Currently the zero check on val to break out of a loop > is a little obscure. Replace the val is zero and break check > with a loop while value is non-zero. >=20 > Signed-off-by: Colin Ian King > --- > drivers/net/wireless/mediatek/mt7601u/phy.c | 4 +--- > 1 file changed, 1 insertion(+), 3 deletions(-) >=20 > diff --git a/drivers/net/wireless/mediatek/mt7601u/phy.c b/drivers/net/wi= reless/mediatek/mt7601u/phy.c > index 06f5702ab4bd..4e0e473caae1 100644 > --- a/drivers/net/wireless/mediatek/mt7601u/phy.c > +++ b/drivers/net/wireless/mediatek/mt7601u/phy.c > @@ -213,9 +213,7 @@ int mt7601u_wait_bbp_ready(struct mt7601u_dev *dev) > =20 > do { > val =3D mt7601u_bbp_rr(dev, MT_BBP_REG_VERSION); > - if (val && ~val) > - break; I think this is not correct since (not considering the cast) we should break =66rom the loop if val !=3D 0 and val !=3D 0xff, so the right approach I gu= ess is: diff --git a/drivers/net/wireless/mediatek/mt7601u/phy.c b/drivers/net/wire= less/mediatek/mt7601u/phy.c index 06f5702ab4bd..d863ab4a66c9 100644 --- a/drivers/net/wireless/mediatek/mt7601u/phy.c +++ b/drivers/net/wireless/mediatek/mt7601u/phy.c @@ -213,7 +213,7 @@ int mt7601u_wait_bbp_ready(struct mt7601u_dev *dev) =20 do { val =3D mt7601u_bbp_rr(dev, MT_BBP_REG_VERSION); - if (val && ~val) + if (val && val !=3D 0xff) break; } while (--i); > - } while (--i); > + } while (val && --i); > =20 > if (!i) { > dev_err(dev->dev, "Error: BBP is not ready\n"); > --=20 > 2.20.1 >=20 --i7F3eY7HS/tUJxUd Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iHUEABYIAB0WIQTquNwa3Txd3rGGn7Y6cBh0uS2trAUCXYTa9wAKCRA6cBh0uS2t rETyAP42WJmgG0YWFN4dtvNtHUZL2FS46W+Tt/OXQTdrQfEfYQEA6DLVOjMTQzuG hmE5irsv5UEh9sDb73OcIUNJYu7aPAg= =LFi7 -----END PGP SIGNATURE----- --i7F3eY7HS/tUJxUd--