From: Jakub Kicinski <jakub.kicinski@netronome.com>
To: "Bjørn Mork" <bjorn@mork.no>
Cc: netdev@vger.kernel.org, linux-usb@vger.kernel.org,
Oliver Neukum <oliver@neukum.org>
Subject: Re: [PATCH net,stable] usbnet: ignore endpoints with invalid wMaxPacketSize
Date: Fri, 20 Sep 2019 19:03:03 -0700 [thread overview]
Message-ID: <20190920190303.149da58a@cakuba.netronome.com> (raw)
In-Reply-To: <20190918121738.6343-1-bjorn@mork.no>
On Wed, 18 Sep 2019 14:17:38 +0200, Bjørn Mork wrote:
> Endpoints with zero wMaxPacketSize are not usable for transferring
> data. Ignore such endpoints when looking for valid in, out and
> status pipes, to make the drivers more robust against invalid and
> meaningless descriptors.
>
> The wMaxPacketSize of these endpoints are used for memory allocations
> and as divisors in many usbnet minidrivers. Avoiding zero is therefore
> critical.
>
> Signed-off-by: Bjørn Mork <bjorn@mork.no>
Fixes tag would be useful. I'm not sure how far into stable we should
backport this.
Is this something that occurs on real devices or protection from
malicious ones?
next prev parent reply other threads:[~2019-09-21 2:03 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-09-18 12:17 [PATCH net,stable] usbnet: ignore endpoints with invalid wMaxPacketSize Bjørn Mork
2019-09-21 2:03 ` Jakub Kicinski [this message]
2019-09-21 12:54 ` Bjørn Mork
2019-09-21 19:30 ` Jakub Kicinski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190920190303.149da58a@cakuba.netronome.com \
--to=jakub.kicinski@netronome.com \
--cc=bjorn@mork.no \
--cc=linux-usb@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=oliver@neukum.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).