From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.7 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 71844C3A5A2 for ; Sun, 22 Sep 2019 21:08:11 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 3A5312070C for ; Sun, 22 Sep 2019 21:08:11 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=netronome-com.20150623.gappssmtp.com header.i=@netronome-com.20150623.gappssmtp.com header.b="LbRVKPEY" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2392917AbfIVVIF (ORCPT ); Sun, 22 Sep 2019 17:08:05 -0400 Received: from mail-pg1-f193.google.com ([209.85.215.193]:45440 "EHLO mail-pg1-f193.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2388679AbfIVVIF (ORCPT ); Sun, 22 Sep 2019 17:08:05 -0400 Received: by mail-pg1-f193.google.com with SMTP id 4so6737446pgm.12 for ; Sun, 22 Sep 2019 14:08:04 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=netronome-com.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:in-reply-to:references :organization:mime-version:content-transfer-encoding; bh=N02DuWV6Ls3abVLlI8h6X8K21ukMEFlJkO/0aLsDK0s=; b=LbRVKPEYYOO6psE0Yw77Hs/lDLbvbwH8YrMPHyagr9mucUEr8xFECka9eq2nyTNqDj a01yizLfeFS4nTPCHzjwVPFNOChkR8WPwpuz83J2MC5xiB5b2DOSHWMlIuH7lUOjQVh6 z1W45WY0YU4bYw3QLcti59jEjmLmgof1zWm8FEgvA12KWoVeJO+xw4jKEhK2U67gf98x aREdIF8OzVfEb4hQRkRH1LAwKHRwskSZcaieRFNpofR3iAG9G6hCD4z4jyuc7OnS08es XsE4V/hOPFetMFiq7GLLhuaojYQPvel27pFMUIV8fZsgqpU/95X6LqqeO8tgkRGNoIMf CR0g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:in-reply-to :references:organization:mime-version:content-transfer-encoding; bh=N02DuWV6Ls3abVLlI8h6X8K21ukMEFlJkO/0aLsDK0s=; b=PCJpGPXIu81JpeHZ2ZJWU1GHWjC8eLQ41LFNZkkk2kxV/3vgewVqXHymWNHd8tf0H9 u/BcMd1KWaIGs3DduwkVQcm6fRkAhm8vvUBTTOcdZ71QYZ2s75jxQXsZ3nNx71difAKk oAdshHzOwONdRdAgfN8+ESiv/u2I/eth/N50yDO8vaEJYVxnWEbhSwvVjqIn0nAPq5qT debeYdWSr0dHdta+/zR49sgYj+aYkP1O/FJOVrcUPxWdcsSVxJzDT8Hl5kyuI2GDbTDm p2kPTo2tB7sa486QijU2BFhFNLKFcc8P7Zwwp+4PYAMmi2CxSVYU703JC8YNXbBJRQFF kk0A== X-Gm-Message-State: APjAAAUAVHUu5XIySnNW8hgAOs2vc76tluAw5IxEtASIMZJD6q+E3QlR GixFA8FKWMedtBjEv7hvkzW9iw== X-Google-Smtp-Source: APXvYqyx2Ki6Glce3kMT9uI6N/7jpfRnMKxmuPdQQpvOkPKiHMkHWfeObbmKV3AUCYAztvbIE7B33g== X-Received: by 2002:a62:3687:: with SMTP id d129mr30557925pfa.199.1569186484473; Sun, 22 Sep 2019 14:08:04 -0700 (PDT) Received: from cakuba.netronome.com (c-73-202-202-92.hsd1.ca.comcast.net. [73.202.202.92]) by smtp.gmail.com with ESMTPSA id k95sm9971958pje.10.2019.09.22.14.08.03 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 22 Sep 2019 14:08:04 -0700 (PDT) Date: Sun, 22 Sep 2019 14:08:00 -0700 From: Jakub Kicinski To: Mao Wenan Cc: , , , , , , Subject: Re: [PATCH v2 net] net: ena: Select DIMLIB for ENA_ETHERNET Message-ID: <20190922140800.6b1ed695@cakuba.netronome.com> In-Reply-To: <20190922053808.117965-1-maowenan@huawei.com> References: <20190921200741.1c3289e8@cakuba.netronome.com> <20190922053808.117965-1-maowenan@huawei.com> Organization: Netronome Systems, Ltd. MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Sun, 22 Sep 2019 13:38:08 +0800, Mao Wenan wrote: > If CONFIG_ENA_ETHERNET=y and CONFIG_DIMLIB=n, > below erros can be found: > drivers/net/ethernet/amazon/ena/ena_netdev.o: In function `ena_dim_work': > ena_netdev.c:(.text+0x21cc): undefined reference to `net_dim_get_rx_moderation' > ena_netdev.c:(.text+0x21cc): relocation truncated to > fit: R_AARCH64_CALL26 against undefined symbol `net_dim_get_rx_moderation' > drivers/net/ethernet/amazon/ena/ena_netdev.o: In function `ena_io_poll': > ena_netdev.c:(.text+0x7bd4): undefined reference to `net_dim' > ena_netdev.c:(.text+0x7bd4): relocation truncated to fit: > R_AARCH64_CALL26 against undefined symbol `net_dim' > > After commit 282faf61a053 ("net: ena: switch to dim algorithm for rx adaptive > interrupt moderation"), it introduces dim algorithm, which configured by CONFIG_DIMLIB. > So, this patch is to select DIMLIB for ENA_ETHERNET. > > Fixes: 282faf61a053 ("net: ena: switch to dim algorithm for rx adaptive interrupt moderation") > Signed-off-by: Mao Wenan Applied, thank you!