From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 05813C3A5A2 for ; Sun, 22 Sep 2019 22:20:58 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id C732820869 for ; Sun, 22 Sep 2019 22:20:57 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=netronome-com.20150623.gappssmtp.com header.i=@netronome-com.20150623.gappssmtp.com header.b="Q9CxQCZV" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729098AbfIVWU4 (ORCPT ); Sun, 22 Sep 2019 18:20:56 -0400 Received: from mail-pg1-f195.google.com ([209.85.215.195]:34243 "EHLO mail-pg1-f195.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726382AbfIVWU4 (ORCPT ); Sun, 22 Sep 2019 18:20:56 -0400 Received: by mail-pg1-f195.google.com with SMTP id y35so1050174pgl.1 for ; Sun, 22 Sep 2019 15:20:55 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=netronome-com.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:in-reply-to:references :organization:mime-version:content-transfer-encoding; bh=PmAznyfs4k+mWd//xBrPme3TcumsUBoHQjEZq6u+NLY=; b=Q9CxQCZVN3CeKim3T14DI+dzH5PlCDTA8QmbsW+C8eax7IIA/NB0aFCLOE5uEMlnah n9HfkK054QH0pzmBa/MaaPHryLTCxiQvGwyx9m2DBJ3+fWXwG4tZ1JBoHBYs79JyChbx r5rFDF448s/NfZ2lrFLEI/35LniKtZVDGfAnyeOltNGUbu+hXauDlNLnNAaQqWncuzo2 +3937Vc7WBUdbsp3LzrmK2ZIuYecnYyYnVMqeOVgiI0Tg/28mg73wkAS2nR2q0eakRY3 9/YK/KVHUUOG6XAHJmFirHgZxtOEbFencrEJwS4yKpWhp/Wx/AxSLIA3VX7LS190gJnR PoVw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:in-reply-to :references:organization:mime-version:content-transfer-encoding; bh=PmAznyfs4k+mWd//xBrPme3TcumsUBoHQjEZq6u+NLY=; b=fcCwq+06F2QuYXKX3bCWnl97fhiaA8Y847a9xTdSQ8a/qI2/VGhNk78BWA3AkyabmK nH0poQfsSzOggpzoJD2Bid0VSo5Kbiz4At8bxLtu1UYfJd7rtCMmuhEPYzLbqFCA8P/W znp1PT2R0ewG563dE47u2XuQk/8Z5i23MuL/6DpxW3XmgCS/jqWsmsLrmPdGpqu+1YrC jQem4xzuDB0N63eUjPsKVdFgTUxFB+dXp+qzLfazb8Un7ow9dAtHBCSiNcYn95+iKVb2 miczmzP+KiD7EXsXusVXsM2PzwSVpQ37vsJsLtdTPpof+VVPJDIjwPKp0WovdaE31bSa XVFw== X-Gm-Message-State: APjAAAVU2gs+r9rDWYVD+rAiKgsvUznC3LY6g2BSQArzNI7MECt5YEfB R3vAQpoc8nFEOghgShDAPOVZ9g== X-Google-Smtp-Source: APXvYqzciIn5+C8G7UZYhYgLD06dOmlQZq70XrUrVD2u2KT92kUx/KmLzyi/sFi09I3djSRu2p/rmQ== X-Received: by 2002:a17:90a:8087:: with SMTP id c7mr17644769pjn.56.1569190380757; Sun, 22 Sep 2019 15:13:00 -0700 (PDT) Received: from cakuba.netronome.com (c-73-202-202-92.hsd1.ca.comcast.net. [73.202.202.92]) by smtp.gmail.com with ESMTPSA id r187sm7877357pfc.105.2019.09.22.15.12.59 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 22 Sep 2019 15:13:00 -0700 (PDT) Date: Sun, 22 Sep 2019 15:12:57 -0700 From: Jakub Kicinski To: Christophe Roullier Cc: , , , , , , , , , , , , Subject: Re: [PATCH 0/5] net: ethernet: stmmac: some fixes and optimization Message-ID: <20190922151257.51173d89@cakuba.netronome.com> In-Reply-To: <20190920053817.13754-1-christophe.roullier@st.com> References: <20190920053817.13754-1-christophe.roullier@st.com> Organization: Netronome Systems, Ltd. MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Fri, 20 Sep 2019 07:38:12 +0200, Christophe Roullier wrote: > Some improvements (manage syscfg as optional clock, update slew rate of > ETH_MDIO pin, Enable gating of the MAC TX clock during TX low-power mode) > Fix warning build message when W=1 There seems to be some new features/cleanups (or improvements as you say) here. Could you explain the negative impact not applying these changes will have? Patches 1 and 3 in particular. net-next is now closed [1], and will reopen some time after the merge window is over. For now we are only expecting fixes for the net tree. Could you (a) provide stronger motivation these changes are fixes; or (b) separate the fixes from improvements? Thank you! [1] https://www.kernel.org/doc/html/latest/networking/netdev-FAQ.html