Netdev List
 help / color / mirror / Atom feed
From: David Miller <davem@davemloft.net>
To: zenczykowski@gmail.com
Cc: netdev@vger.kernel.org, keescook@google.com, dvyukov@google.com,
	edumazet@google.com, maheshb@google.com, lorenzo@google.com
Subject: Re: [PATCH] net-icmp: remove ping_group_range sysctl
Date: Tue, 24 Sep 2019 21:33:52 +0200 (CEST)	[thread overview]
Message-ID: <20190924.213352.2279175030201650840.davem@davemloft.net> (raw)
In-Reply-To: <CANP3RGeZaGD5JLw4VCLXe_6qmrGRLjROJuUNwbysq_1BhNbKOg@mail.gmail.com>

From: Maciej Żenczykowski <zenczykowski@gmail.com>
Date: Tue, 24 Sep 2019 16:47:00 +0200

>> Removing this is going to break things, you can't just remove a sysctl
>> because "oh it was a bad idea to add this, sorry."
> 
> Yeah, I know... but do you have any other suggestions?
> 
> Would you take an alternative to make the default wide opened?

This also could break things.

The horse has left the barn on this one.

> Perhaps having it as a non-namespace aware global setting (with a
> default of on) would be more palatable?

Also could break things.

You're going to have to change this in a way such that the administrator
has to explicitly ask for the new behavior.

      reply	other threads:[~2019-09-24 19:33 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-09-19 10:39 [PATCH] net-icmp: remove ping_group_range sysctl Maciej Żenczykowski
2019-09-24 14:40 ` David Miller
2019-09-24 14:47   ` Maciej Żenczykowski
2019-09-24 19:33     ` David Miller [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190924.213352.2279175030201650840.davem@davemloft.net \
    --to=davem@davemloft.net \
    --cc=dvyukov@google.com \
    --cc=edumazet@google.com \
    --cc=keescook@google.com \
    --cc=lorenzo@google.com \
    --cc=maheshb@google.com \
    --cc=netdev@vger.kernel.org \
    --cc=zenczykowski@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox