From: Vlad Buslov <vladbu@mellanox.com>
To: netdev@vger.kernel.org
Cc: jhs@mojatatu.com, xiyou.wangcong@gmail.com, jiri@resnulli.us,
davem@davemloft.net, Vlad Buslov <vladbu@mellanox.com>
Subject: [PATCH net v3 0/3] Fix Qdisc destroy issues caused by adding fine-grained locking to filter API
Date: Tue, 24 Sep 2019 18:51:15 +0300 [thread overview]
Message-ID: <20190924155118.2488-1-vladbu@mellanox.com> (raw)
TC filter API unlocking introduced several new fine-grained locks. The
change caused sleeping-while-atomic BUGs in several Qdiscs that call cls
APIs which need to obtain new mutex while holding sch tree spinlock. This
series fixes affected Qdiscs by ensuring that cls API that became sleeping
is only called outside of sch tree lock critical section.
Vlad Buslov (3):
net: sched: sch_htb: don't call qdisc_put() while holding tree lock
net: sched: multiq: don't call qdisc_put() while holding tree lock
net: sched: sch_sfb: don't call qdisc_put() while holding tree lock
net/sched/sch_htb.c | 4 +++-
net/sched/sch_multiq.c | 23 ++++++++++++++++-------
net/sched/sch_sfb.c | 7 ++++---
3 files changed, 23 insertions(+), 11 deletions(-)
--
2.21.0
next reply other threads:[~2019-09-24 15:51 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-09-24 15:51 Vlad Buslov [this message]
2019-09-24 15:51 ` [PATCH net v3 1/3] net: sched: sch_htb: don't call qdisc_put() while holding tree lock Vlad Buslov
2019-09-24 15:51 ` [PATCH net v3 2/3] net: sched: multiq: " Vlad Buslov
2019-09-24 15:51 ` [PATCH net v3 3/3] net: sched: sch_sfb: " Vlad Buslov
2019-09-24 16:42 ` [PATCH net v3 0/3] Fix Qdisc destroy issues caused by adding fine-grained locking to filter API Cong Wang
2019-09-27 10:15 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190924155118.2488-1-vladbu@mellanox.com \
--to=vladbu@mellanox.com \
--cc=davem@davemloft.net \
--cc=jhs@mojatatu.com \
--cc=jiri@resnulli.us \
--cc=netdev@vger.kernel.org \
--cc=xiyou.wangcong@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox