Netdev List
 help / color / mirror / Atom feed
From: "Uwe Kleine-König" <uwe@kleine-koenig.org>
To: Tal Gilboa <talgi@mellanox.com>,
	Saeed Mahameed <saeedm@mellanox.com>,
	David Miller <davem@davemloft.net>
Cc: netdev@vger.kernel.org
Subject: [PATCH v2] dimlib: make DIMLIB a hidden symbol
Date: Tue, 24 Sep 2019 18:02:59 +0200	[thread overview]
Message-ID: <20190924160259.10987-1-uwe@kleine-koenig.org> (raw)
In-Reply-To: <20190924.164528.724219923520816886.davem@davemloft.net>

According to Tal Gilboa the only benefit from DIM comes from a driver
that uses it. So it doesn't make sense to make this symbol user visible,
instead all drivers that use it should select it (as is already the case
AFAICT).

Signed-off-by: Uwe Kleine-König <uwe@kleine-koenig.org>
---
Hello David,

On Tue, Sep 24, 2019 at 04:45:28PM +0200, David Miller wrote:
> Since this doesn't apply due to the moderation typo being elsewhere, I'd
> really like you to fix up this submission to properly be against 'net'.

I thought it would be possible to git-apply my patch with the -3 option.
I even tested that, but obviously it only applies to my tree that has
the git object with the typo fixed. Sorry for the extra effort I'm
forcing on you. This patch applies to your public tree from just now.

Best regads
Uwe

 lib/Kconfig | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/lib/Kconfig b/lib/Kconfig
index 4e6b1c3e4c98..d7fc9eb33b9b 100644
--- a/lib/Kconfig
+++ b/lib/Kconfig
@@ -555,8 +555,7 @@ config SIGNATURE
 	  Implementation is done using GnuPG MPI library
 
 config DIMLIB
-	bool "DIM library"
-	default y
+	bool
 	help
 	  Dynamic Interrupt Moderation library.
 	  Implements an algorithm for dynamically change CQ modertion values
-- 
2.23.0


  reply	other threads:[~2019-09-24 16:03 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-09-20 13:31 [PATCH] dimlib: make DIMLIB a hidden symbol Uwe Kleine-König
2019-09-20 17:02 ` Tal Gilboa
2019-09-20 17:41   ` Randy Dunlap
2019-09-20 17:58   ` Uwe Kleine-König
2019-09-25  7:59   ` Kiyanovski, Arthur
2019-09-22  3:06 ` Jakub Kicinski
2019-09-23  6:18   ` Uwe Kleine-König
2019-09-24 14:45 ` David Miller
2019-09-24 16:02   ` Uwe Kleine-König [this message]
2019-09-26  0:18     ` [PATCH v2] " Randy Dunlap
2019-09-27  7:51     ` David Miller
2019-09-30 19:34 ` [PATCH] " Geert Uytterhoeven

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190924160259.10987-1-uwe@kleine-koenig.org \
    --to=uwe@kleine-koenig.org \
    --cc=davem@davemloft.net \
    --cc=netdev@vger.kernel.org \
    --cc=saeedm@mellanox.com \
    --cc=talgi@mellanox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox