From: xiaolinkui <xiaolinkui@kylinos.cn>
To: davem@davemloft.net
Cc: netdev@vger.kernel.org, xiaolinkui <xiaolinkui@kylinos.cn>
Subject: [PATCH] net: use unlikely for dql_avail case
Date: Wed, 25 Sep 2019 10:40:43 +0800 [thread overview]
Message-ID: <20190925024043.31030-1-xiaolinkui@kylinos.cn> (raw)
This is an unlikely case, use unlikely() on it seems logical.
Signed-off-by: xiaolinkui <xiaolinkui@kylinos.cn>
---
include/linux/netdevice.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/include/linux/netdevice.h b/include/linux/netdevice.h
index 88292953aa6f..005f3da1b13d 100644
--- a/include/linux/netdevice.h
+++ b/include/linux/netdevice.h
@@ -3270,7 +3270,7 @@ static inline void netdev_tx_completed_queue(struct netdev_queue *dev_queue,
*/
smp_mb();
- if (dql_avail(&dev_queue->dql) < 0)
+ if (unlikely(dql_avail(&dev_queue->dql) < 0))
return;
if (test_and_clear_bit(__QUEUE_STATE_STACK_XOFF, &dev_queue->state))
--
2.17.1
next reply other threads:[~2019-09-25 2:41 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-09-25 2:40 xiaolinkui [this message]
2019-09-25 12:25 ` [PATCH] net: use unlikely for dql_avail case Daniel Borkmann
2019-09-26 22:52 ` Eric Dumazet
-- strict thread matches above, loose matches on Subject: below --
2019-08-22 6:58 xiaolinkui
2019-08-24 21:23 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190925024043.31030-1-xiaolinkui@kylinos.cn \
--to=xiaolinkui@kylinos.cn \
--cc=davem@davemloft.net \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox