From: "Michael S. Tsirkin" <mst@redhat.com>
To: Tiwei Bie <tiwei.bie@intel.com>
Cc: jasowang@redhat.com, alex.williamson@redhat.com,
maxime.coquelin@redhat.com, linux-kernel@vger.kernel.org,
kvm@vger.kernel.org, virtualization@lists.linux-foundation.org,
netdev@vger.kernel.org, dan.daly@intel.com,
cunming.liang@intel.com, zhihong.wang@intel.com,
lingshan.zhu@intel.com
Subject: Re: [PATCH] vhost: introduce mdev based hardware backend
Date: Thu, 26 Sep 2019 09:26:22 -0400 [thread overview]
Message-ID: <20190926091945-mutt-send-email-mst@kernel.org> (raw)
In-Reply-To: <20190926131439.GA11652@___>
On Thu, Sep 26, 2019 at 09:14:39PM +0800, Tiwei Bie wrote:
> > 4. Does device need to limit max ring size?
> > 5. Does device need to limit max number of queues?
>
> I think so. It's helpful to have ioctls to report the max
> ring size and max number of queues.
Also, let's not repeat the vhost net mistakes, let's lock
everything to the order required by the virtio spec,
checking status bits at each step.
E.g.:
set backend features
set features
detect and program vqs
enable vqs
enable driver
and check status at each step to force the correct order.
e.g. don't allow enabling vqs after driver ok, etc
--
MST
next prev parent reply other threads:[~2019-09-26 13:26 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-09-26 4:54 [PATCH] vhost: introduce mdev based hardware backend Tiwei Bie
2019-09-26 8:35 ` Michael S. Tsirkin
2019-09-26 13:14 ` Tiwei Bie
2019-09-26 13:26 ` Michael S. Tsirkin [this message]
2019-09-26 13:34 ` Tiwei Bie
2019-09-27 3:27 ` Jason Wang
2019-09-27 9:41 ` Michael S. Tsirkin
2019-09-27 12:17 ` Jason Wang
2019-09-27 12:46 ` Michael S. Tsirkin
2019-09-27 13:17 ` Jason Wang
2019-09-27 13:23 ` Michael S. Tsirkin
2019-09-29 7:39 ` Jason Wang
2019-09-26 14:05 ` kbuild test robot
2019-09-27 3:46 ` Jason Wang
2019-09-27 3:51 ` Jason Wang
2019-09-27 4:26 ` Tiwei Bie
2019-09-27 4:54 ` Tiwei Bie
2019-09-27 7:14 ` Jason Wang
2019-09-27 8:04 ` Tiwei Bie
2019-09-27 8:31 ` Jason Wang
2019-09-27 7:17 ` Jason Wang
2019-09-27 8:47 ` Jason Wang
2019-09-27 9:38 ` Michael S. Tsirkin
2019-09-27 12:15 ` Jason Wang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190926091945-mutt-send-email-mst@kernel.org \
--to=mst@redhat.com \
--cc=alex.williamson@redhat.com \
--cc=cunming.liang@intel.com \
--cc=dan.daly@intel.com \
--cc=jasowang@redhat.com \
--cc=kvm@vger.kernel.org \
--cc=lingshan.zhu@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=maxime.coquelin@redhat.com \
--cc=netdev@vger.kernel.org \
--cc=tiwei.bie@intel.com \
--cc=virtualization@lists.linux-foundation.org \
--cc=zhihong.wang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).