From: Andrew Lunn <andrew@lunn.ch>
To: Vasundhara Volam <vasundhara-v.volam@broadcom.com>
Cc: davem@davemloft.net, netdev@vger.kernel.org,
Jiri Pirko <jiri@mellanox.com>,
Michael Chan <michael.chan@broadcom.com>
Subject: Re: [PATCH net] devlink: Fix error handling in param and info_get dumpit cb
Date: Thu, 26 Sep 2019 14:27:26 +0200 [thread overview]
Message-ID: <20190926122726.GE1864@lunn.ch> (raw)
In-Reply-To: <1569490554-21238-1-git-send-email-vasundhara-v.volam@broadcom.com>
On Thu, Sep 26, 2019 at 03:05:54PM +0530, Vasundhara Volam wrote:
> If any of the param or info_get op returns error, dumpit cb is
> skipping to dump remaining params or info_get ops for all the
> drivers.
>
> Instead skip only for the param/info_get op which returned error
> and continue to dump remaining information, except if the return
> code is EMSGSIZE.
Hi Vasundhara
How do we get to see something did fail? If it failed, it failed for a
reason, and we want to know.
What is your real use case here? What is failing, and why are you
O.K. to skip this failure?
Andrew
next prev parent reply other threads:[~2019-09-26 12:27 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-09-26 9:35 [PATCH net] devlink: Fix error handling in param and info_get dumpit cb Vasundhara Volam
2019-09-26 12:27 ` Andrew Lunn [this message]
2019-09-27 4:58 ` Vasundhara Volam
2019-09-27 12:31 ` Andrew Lunn
2019-09-27 13:08 ` Jiri Pirko
2019-09-27 13:37 ` Vasundhara Volam
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190926122726.GE1864@lunn.ch \
--to=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=jiri@mellanox.com \
--cc=michael.chan@broadcom.com \
--cc=netdev@vger.kernel.org \
--cc=vasundhara-v.volam@broadcom.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).