From: Andrew Lunn <andrew@lunn.ch>
To: Dan Carpenter <dan.carpenter@oracle.com>
Cc: "Alvaro G. M" <alvaro.gamez@hazent.com>,
Radhey Shyam Pandey <radhey.shyam.pandey@xilinx.com>,
"David S. Miller" <davem@davemloft.net>,
Michal Simek <michal.simek@xilinx.com>,
Russell King <linux@armlinux.org.uk>,
netdev@vger.kernel.org, kernel-janitors@vger.kernel.org
Subject: Re: [PATCH net] net: axienet: fix a signedness bug in probe
Date: Thu, 26 Sep 2019 15:24:58 +0200 [thread overview]
Message-ID: <20190926132458.GC20927@lunn.ch> (raw)
In-Reply-To: <20190926131811.GG29696@kadam>
> The get_phy_mode() function seem like they lend themselves to creating
> these bugs. The ->phy_mode variables tend to be declared in the driver
> so it would require quite a few patches to make them all int and I'm not
> sure that's more beautiful. Andrew Lunn's idea to update the API would
> probably be a good idea.
Hi Dan
I started on it. Once net-next has opened, and 0-day has compile
tested my changes, i will post the code for review.
Andrew
next prev parent reply other threads:[~2019-09-26 13:25 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-09-25 10:59 [PATCH net] net: axienet: fix a signedness bug in probe Dan Carpenter
2019-09-25 11:05 ` Alvaro G. M
2019-09-25 11:35 ` David Miller
2019-09-25 12:14 ` Andrew Lunn
2019-09-26 13:18 ` Dan Carpenter
2019-09-26 13:24 ` Andrew Lunn [this message]
2019-09-25 12:01 ` Radhey Shyam Pandey
2019-09-27 8:17 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190926132458.GC20927@lunn.ch \
--to=andrew@lunn.ch \
--cc=alvaro.gamez@hazent.com \
--cc=dan.carpenter@oracle.com \
--cc=davem@davemloft.net \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=michal.simek@xilinx.com \
--cc=netdev@vger.kernel.org \
--cc=radhey.shyam.pandey@xilinx.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).