From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4A7E1C4360C for ; Fri, 27 Sep 2019 08:04:16 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 2A21D217D7 for ; Fri, 27 Sep 2019 08:04:16 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726783AbfI0IEP (ORCPT ); Fri, 27 Sep 2019 04:04:15 -0400 Received: from shards.monkeyblade.net ([23.128.96.9]:57022 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725804AbfI0IEP (ORCPT ); Fri, 27 Sep 2019 04:04:15 -0400 Received: from localhost (unknown [65.39.69.237]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (Client did not present a certificate) (Authenticated sender: davem-davemloft) by shards.monkeyblade.net (Postfix) with ESMTPSA id 0200E14DD9E5A; Fri, 27 Sep 2019 01:04:13 -0700 (PDT) Date: Fri, 27 Sep 2019 10:04:12 +0200 (CEST) Message-Id: <20190927.100412.283048791655860337.davem@davemloft.net> To: dan.carpenter@oracle.com Cc: claudiu.manoil@nxp.com, netdev@vger.kernel.org, kernel-janitors@vger.kernel.org Subject: Re: [PATCH net] enetc: Fix a signedness bug in enetc_of_get_phy() From: David Miller In-Reply-To: <20190925105714.GF3264@mwanda> References: <20190925105714.GF3264@mwanda> X-Mailer: Mew version 6.8 on Emacs 26.2 Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Fri, 27 Sep 2019 01:04:14 -0700 (PDT) Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org From: Dan Carpenter Date: Wed, 25 Sep 2019 13:57:14 +0300 > The "priv->if_mode" is type phy_interface_t which is an enum. In this > context GCC will treat the enum as an unsigned int so this error > handling is never triggered. > > Fixes: d4fd0404c1c9 ("enetc: Introduce basic PF and VF ENETC ethernet drivers") > Signed-off-by: Dan Carpenter Applied.