From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7003DC388F4 for ; Fri, 27 Sep 2019 21:42:57 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 4459C21655 for ; Fri, 27 Sep 2019 21:42:57 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=netronome-com.20150623.gappssmtp.com header.i=@netronome-com.20150623.gappssmtp.com header.b="sGZfP/z9" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726470AbfI0Vms (ORCPT ); Fri, 27 Sep 2019 17:42:48 -0400 Received: from mail-pg1-f194.google.com ([209.85.215.194]:33657 "EHLO mail-pg1-f194.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725815AbfI0Vmr (ORCPT ); Fri, 27 Sep 2019 17:42:47 -0400 Received: by mail-pg1-f194.google.com with SMTP id i30so4169637pgl.0 for ; Fri, 27 Sep 2019 14:42:47 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=netronome-com.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:in-reply-to:references :organization:mime-version:content-transfer-encoding; bh=Lzcnw0iAcIFwZNCYEwiqETTo7mFYOXKonShWkT8groo=; b=sGZfP/z9N7kBYff/yn481rZ/m6Z9TK6lqaAfFkUlClJYaX8LJPJD0042nr+RR3kNgl L8pFTcb0BAOChMz1+gAVJoDsfySeQo0Fnr0M1vXJFjjh8Z5W4DCICoF+7zkY5cJm0Nyf y+AnIpfEzF2ChKoi9ajpC/gQP/wGShzwwUhQIKwQoa/Hqimb6p5zQDZpSzHQEm7kOvJ8 9mkCLMkFNfZzwHE5YXzSjvy/ik4EG5Q3GDmViRu29WVrQApCyARAWK969W8a7bTabQi6 WqByiOseyL9LLbeZy4lv7mAJKqWfhCX08Daalfg5JBz1TRuQaXpsIpIwuzozUVgYh01S +EfA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:in-reply-to :references:organization:mime-version:content-transfer-encoding; bh=Lzcnw0iAcIFwZNCYEwiqETTo7mFYOXKonShWkT8groo=; b=MFwKpvFAh5S853saoMq+kmzQx8zswQN4N67LjfkcHeBpNos8m5JCnOzYvB5kX2orEU M8EITkOIJzQESff4+IgtFE36HvQVaRXESVLCkmqrl60AlZGxBeii55+piQ4JMNzNFd79 HtGLd3+x6jBOrvEC9kJt8HTFu7577P6g1d6V034g6TI9yKrDcO57+C3pCLmiQlj7aula oi3tafEo1Eeh42uAAadG6lwKJ6qQOldeS7AYw56IjrovsKaQZYOk/fw1W3pVtAkRbfJ7 bix79bWKYEZCaqwC/q8ZJRwSqdDl/FOxzTMQpEnnhOsDfsj1m5LacmfIZClNcEbiwgCx R4Ow== X-Gm-Message-State: APjAAAX/2aUt9VYFQV07LKj6lI75npujD00TDLt9OO7fY33elQOtwnz1 KrcRF9cZA4GAaxU7UVG5RO3VFA== X-Google-Smtp-Source: APXvYqylvxizWriFlZFI3My3E7wjF1M17Xv3jfridbykbRDhmf/+GPf8eTOyqqe9JtmyjBQw57nNfA== X-Received: by 2002:a65:628a:: with SMTP id f10mr11289856pgv.155.1569620566828; Fri, 27 Sep 2019 14:42:46 -0700 (PDT) Received: from cakuba.netronome.com ([66.60.152.14]) by smtp.gmail.com with ESMTPSA id y138sm4035112pfb.174.2019.09.27.14.42.45 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 27 Sep 2019 14:42:46 -0700 (PDT) Date: Fri, 27 Sep 2019 14:42:42 -0700 From: Jakub Kicinski To: Markus Elfring Cc: Navid Emamdoost , netdev@vger.kernel.org, oss-drivers@netronome.com, Navid Emamdoost , Kangjie Lu , Stephen A McCamant , Colin Ian King , "David S. Miller" , John Hurley , Pablo Neira , linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org Subject: Re: [PATCH v3] nfp: abm: fix memory leak in nfp_abm_u32_knode_replace Message-ID: <20190927144242.7e0d8fde@cakuba.netronome.com> In-Reply-To: <1cde6417-5942-598b-3670-c0a7227ffe25@web.de> References: <20190927015157.20070-1-navid.emamdoost@gmail.com> <1cde6417-5942-598b-3670-c0a7227ffe25@web.de> Organization: Netronome Systems, Ltd. MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Fri, 27 Sep 2019 14:12:42 +0200, Markus Elfring wrote: > > Updated other gotos to have correct errno returned, too. > > How do you think about to add a jump target here? > > > > +++ b/drivers/net/ethernet/netronome/nfp/abm/cls.c > > @@ -176,8 +176,10 @@ nfp_abm_u32_knode_replace(struct nfp_abm_link *alink, > > u8 mask, val; > > int err; > > > > - if (!nfp_abm_u32_check_knode(alink->abm, knode, proto, extack)) > > + if (!nfp_abm_u32_check_knode(alink->abm, knode, proto, extack)) { > > + err = -EOPNOTSUPP; > > goto err_delete; > > + } > > > > tos_off = proto == htons(ETH_P_IP) ? 16 : 20; > > - goto err_delete; > + goto e_opnotsupp; > > > > @@ -221,7 +227,7 @@ nfp_abm_u32_knode_replace(struct nfp_abm_link *alink, > > > > +e_opnotsupp: > + err = -EOPNOTSUPP; > > > err_delete: > > nfp_abm_u32_knode_delete(alink, knode); > > - return -EOPNOTSUPP; > > + return err; > > } > > > > static int nfp_abm_setup_tc_block_cb(enum tc_setup_type type, > > > Can such a change variant be a bit nicer? Definitely not. Looks good as is, thanks Navid!