From: Stephen Hemminger <stephen@networkplumber.org>
To: Roopa Prabhu <roopa@cumulusnetworks.com>
Cc: dsahern@gmail.com, netdev@vger.kernel.org, nikolay@cumulusnetworks.com
Subject: Re: [PATCH iproute2 net-next 1/2] bridge: fdb get support
Date: Sat, 28 Sep 2019 08:46:41 -0700 [thread overview]
Message-ID: <20190928084641.69233a5a@hermes.lan> (raw)
In-Reply-To: <1569646104-358-2-git-send-email-roopa@cumulusnetworks.com>
On Fri, 27 Sep 2019 21:48:23 -0700
Roopa Prabhu <roopa@cumulusnetworks.com> wrote:
Overall, looks good.
> + if (print_fdb(answer, (void *)stdout) < 0) {
Cast to void is not necessary in C (it is in C++)
next prev parent reply other threads:[~2019-09-28 15:46 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-09-28 4:48 [PATCH iproute2 net-next 0/2] support for bridge fdb and neigh get Roopa Prabhu
2019-09-28 4:48 ` [PATCH iproute2 net-next 1/2] bridge: fdb get support Roopa Prabhu
2019-09-28 15:46 ` Stephen Hemminger [this message]
2019-09-28 20:20 ` Roopa Prabhu
2019-09-28 4:48 ` [PATCH iproute2 net-next 2/2] ipneigh: neigh " Roopa Prabhu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190928084641.69233a5a@hermes.lan \
--to=stephen@networkplumber.org \
--cc=dsahern@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=nikolay@cumulusnetworks.com \
--cc=roopa@cumulusnetworks.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).