From: Andrew Lunn <andrew@lunn.ch>
To: Zoran Stojsavljevic <zoran.stojsavljevic@gmail.com>
Cc: netdev@vger.kernel.org
Subject: Re: DSA driver kernel extension for dsa mv88e6190 switch
Date: Mon, 30 Sep 2019 03:44:40 +0200 [thread overview]
Message-ID: <20190930014440.GC6032@lunn.ch> (raw)
In-Reply-To: <CAGAf8LzJ56wjWxywnGWB1aOFm9B8xQhMgHFQfkVgOFWePzDfsw@mail.gmail.com>
> I wrote my (very first) public GIST about that. Please, could you
> review it, and point to the any logical bugs in there?
> https://gist.github.com/ZoranStojsavljevic/423b96e2ca3bd581f7ce417cb410c465
The very last line is wrong.
ifconfig eth0 192.168.1.4 up
You should put the IP address on the bridge, not the master device
eth0.
ip addr add 192.168.1.4/24 dev br0
FYI: ifconfig has been deprecated for maybe a decade?
Andrew
next prev parent reply other threads:[~2019-09-30 1:46 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-09-23 18:38 DSA driver kernel extension for dsa mv88e6190 switch Zoran Stojsavljevic
2019-09-23 19:17 ` Andrew Lunn
2019-09-26 13:23 ` Zoran Stojsavljevic
2019-09-26 13:38 ` Andrew Lunn
2019-09-27 23:00 ` Zoran Stojsavljevic
2019-09-28 15:20 ` Andrew Lunn
2019-09-29 6:55 ` Zoran Stojsavljevic
2019-09-30 1:44 ` Andrew Lunn [this message]
2019-09-30 5:51 ` Zoran Stojsavljevic
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190930014440.GC6032@lunn.ch \
--to=andrew@lunn.ch \
--cc=netdev@vger.kernel.org \
--cc=zoran.stojsavljevic@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).