From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.5 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4D9C6C4360C for ; Mon, 30 Sep 2019 07:47:53 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id DE53620842 for ; Mon, 30 Sep 2019 07:47:52 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729495AbfI3Hru (ORCPT ); Mon, 30 Sep 2019 03:47:50 -0400 Received: from smtp3.goneo.de ([85.220.129.37]:57964 "EHLO smtp3.goneo.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725767AbfI3Hrt (ORCPT ); Mon, 30 Sep 2019 03:47:49 -0400 Received: from localhost (localhost [127.0.0.1]) by smtp3.goneo.de (Postfix) with ESMTP id 9395A23F739; Mon, 30 Sep 2019 09:47:45 +0200 (CEST) X-Virus-Scanned: by goneo Received: from smtp3.goneo.de ([127.0.0.1]) by localhost (smtp3.goneo.de [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id MD998ao4vd6d; Mon, 30 Sep 2019 09:47:44 +0200 (CEST) Received: from lem-wkst-02.lemonage (hq.lemonage.de [87.138.178.34]) by smtp3.goneo.de (Postfix) with ESMTPSA id 2041D23F63A; Mon, 30 Sep 2019 09:47:43 +0200 (CEST) Date: Mon, 30 Sep 2019 09:47:37 +0200 From: Lars Poeschel To: Rob Herring Cc: "David S. Miller" , Mark Rutland , "open list:NFC SUBSYSTEM" , "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" , open list , Johan Hovold , Simon Horman Subject: Re: [PATCH v8 2/7] nfc: pn532: Add uart phy docs and rename it Message-ID: <20190930074737.GA24353@lem-wkst-02.lemonage> References: <20190919091645.16439-1-poeschel@lemonage.de> <20190919091645.16439-2-poeschel@lemonage.de> <20190927155209.GA6261@bogus> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20190927155209.GA6261@bogus> User-Agent: Mutt/1.10.1 (2018-07-13) Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Fri, Sep 27, 2019 at 10:52:09AM -0500, Rob Herring wrote: > On Thu, Sep 19, 2019 at 11:16:39AM +0200, Lars Poeschel wrote: > > This adds documentation about the uart phy to the pn532 binding doc. As > > the filename "pn533-i2c.txt" is not appropriate any more, rename it to > > the more general "pn532.txt". > > This also documents the deprecation of the compatible strings ending > > with "...-i2c". > > > > Cc: Johan Hovold > > Cc: Simon Horman > > Signed-off-by: Lars Poeschel > > --- > > Changes in v8: > > - Update existing binding doc instead of adding a new one: > > - Add uart phy example > > - Add general "pn532" compatible string > > - Deprecate "...-i2c" compatible strings > > - Rename file to a more general filename > > - Intentionally drop Rob's Reviewed-By as I guess this rather big change > > requires a new review > > > > Changes in v7: > > - Accidentally lost Rob's Reviewed-By > > > > Changes in v6: > > - Rebased the patch series on v5.3-rc5 > > - Picked up Rob's Reviewed-By > > > > Changes in v4: > > - Add documentation about reg property in case of i2c > > > > Changes in v3: > > - seperate binding doc instead of entry in trivial-devices.txt > > > > .../devicetree/bindings/net/nfc/pn532.txt | 46 +++++++++++++++++++ > > .../devicetree/bindings/net/nfc/pn533-i2c.txt | 29 ------------ > > 2 files changed, 46 insertions(+), 29 deletions(-) > > create mode 100644 Documentation/devicetree/bindings/net/nfc/pn532.txt > > delete mode 100644 Documentation/devicetree/bindings/net/nfc/pn533-i2c.txt > > In the future, use '-M' option (I recommend making this the default). As David already requested a next version of the patchset, I will do it in v9. > > > > diff --git a/Documentation/devicetree/bindings/net/nfc/pn532.txt b/Documentation/devicetree/bindings/net/nfc/pn532.txt > > new file mode 100644 > > index 000000000000..f0591f160bee > > --- /dev/null > > +++ b/Documentation/devicetree/bindings/net/nfc/pn532.txt > > @@ -0,0 +1,46 @@ > > +* NXP Semiconductors PN532 NFC Controller > > + > > +Required properties: > > +- compatible: Should be > > + - "nxp,pn532" Place a node with this inside the devicetree node of the bus > > + where the NFC chip is connected to. > > + Currently the kernel has phy bindings for uart and i2c. > > + - "nxp,pn532-i2c" (DEPRECATED) only works for the i2c binding. > > + - "nxp,pn533-i2c" (DEPRECATED) only works for the i2c binding. > > No more pm533 support? If you ask me, no. NXP sells more or less two versions of this chip: pn532 and pn533. The pn532 is the version with i2c and uart interface, the pn533 only has an usb interface. So I would say "nxp,pn533-i2c" was wrong and I dropped it. > > + > > +Required properties if connected on i2c: > > +- clock-frequency: I²C work frequency. > > +- reg: for the I²C bus address. This is fixed at 0x24 for the PN532. > > +- interrupts: GPIO interrupt to which the chip is connected > > UART attached case has no irq? I guess it could just start sending > data... Well, the chip has it (as said above, it is the same as the i2c chip) but it is not an use case for me. At the moment I have no hardware to test this with. So I did not implement it in the uart phy driver. Solution is: If the chip is in sleep mode, send it some special "wake-up" paket over uard and wait until it actually wakes up. > > + > > +Optional SoC Specific Properties: > > +- pinctrl-names: Contains only one value - "default". > > +- pintctrl-0: Specifies the pin control groups used for this controller. > > + > > +Example (for ARM-based BeagleBone with PN532 on I2C2): > > + > > +&i2c2 { > > + > > + > > + pn532: pn532@24 { > > nfc@24 Ok. > > + > > + compatible = "nxp,pn532"; > > + > > + reg = <0x24>; > > + clock-frequency = <400000>; > > + > > + interrupt-parent = <&gpio1>; > > + interrupts = <17 IRQ_TYPE_EDGE_FALLING>; > > + > > + }; > > +}; > > + > > +Example (for PN532 connected via uart): > > + > > +uart4: serial@49042000 { > > + compatible = "ti,omap3-uart"; > > + > > + pn532: nfc { > > + compatible = "nxp,pn532"; > > + }; > > +};