From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.0 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id ADB44C32792 for ; Mon, 30 Sep 2019 23:18:21 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 7E13B20842 for ; Mon, 30 Sep 2019 23:18:21 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=netronome-com.20150623.gappssmtp.com header.i=@netronome-com.20150623.gappssmtp.com header.b="tj5Bg7oa" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1732048AbfI3XSU (ORCPT ); Mon, 30 Sep 2019 19:18:20 -0400 Received: from mail-qt1-f195.google.com ([209.85.160.195]:34638 "EHLO mail-qt1-f195.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727621AbfI3XSU (ORCPT ); Mon, 30 Sep 2019 19:18:20 -0400 Received: by mail-qt1-f195.google.com with SMTP id 3so19286539qta.1 for ; Mon, 30 Sep 2019 16:18:18 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=netronome-com.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:in-reply-to:references :organization:mime-version:content-transfer-encoding; bh=+K7vISo63seW+fv9e2awwFfZvkHDT6dGzGUlDkiOv4I=; b=tj5Bg7oa+tGI3KiWZ3R1MUj3EZzTH0QoravQqXqqY+q6HRaApaGPdk5Nq7LoBoycS9 rProm0oYTx/sp2TLsZ5z41BMDy14KnrW0KwE4SLnwrPFeqHyxoLZpxhsfZ4Y2iwScuwd Yvy0uEkYCAnOnBmt9Fz2NuXZVd1jZqO092PylMjjlNNCgDNN60BDVNCsfFozO6O3Xxl3 kge1NZuWf5ukSL+zKpdLDtsJQE5Po0aVY3A0DJ4WPKDDvf+Gmp/KIAAxE+cgmihfk33G wiqFMDWmKB0/IoOyjeDx+dJYjQPftM1ldwuJ9R5HLibd8FMByGjof5GmBaTUkHaRh2oF X9kQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:in-reply-to :references:organization:mime-version:content-transfer-encoding; bh=+K7vISo63seW+fv9e2awwFfZvkHDT6dGzGUlDkiOv4I=; b=VrQRg0bEdu5WVbgtWebHJoi5XihCU0bDX+J8nEkH5RDt30UJjr1iy5WWC+TCdFtLdE rwMAAHO20KLll/rEb0R+HdTfz+ZgEFZ0HrfDO9zWrBnZxx+UgKW3fuolE3ry8Pe7wWXY 3Xh4W2P0We6cIrdhMoRqGBYIcDRyzJHqYt9j+cg75ET20rekYkZJu4m8b2aR3VnDCfIf i5bxMUQP9o0ex1mryYGtVmfFV9Pn0uFcxBt/qcuHNoBN+uxpGfmxfLn97nI+qn5QeBNb bRdIFkK6wESNcjQQjyMGUbx0bCadYKoRFnT65JtvXehtcm4/Bgwslf5CoLb4gCXFNIBB GlLQ== X-Gm-Message-State: APjAAAVnekDbFdU6l54c+X2Ryn8Ma968/bYB/o1ccrbMcWkZL6kL8wKZ mXxjkR8hyp62IpCTWSjllYpHYw== X-Google-Smtp-Source: APXvYqzlI5zUao25wiclYxdwIkv/zreglQewx+l+8w/s3z8i2q2KXmAR88Gq86chESrrW3V5Zzo8ZQ== X-Received: by 2002:a0c:ffa7:: with SMTP id d7mr22258056qvv.12.1569885497995; Mon, 30 Sep 2019 16:18:17 -0700 (PDT) Received: from cakuba.netronome.com ([66.60.152.14]) by smtp.gmail.com with ESMTPSA id w73sm6817942qkb.111.2019.09.30.16.18.16 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 30 Sep 2019 16:18:17 -0700 (PDT) Date: Mon, 30 Sep 2019 16:18:14 -0700 From: Jakub Kicinski To: Andrii Nakryiko Cc: Song Liu , Andrii Nakryiko , bpf , Networking , Alexei Starovoitov , Daniel Borkmann , Kernel Team Subject: Re: [PATCH bpf-next 2/6] libbpf: move bpf_helpers.h, bpf_endian.h into libbpf Message-ID: <20190930161814.381c9bb0@cakuba.netronome.com> In-Reply-To: References: <20190930185855.4115372-1-andriin@fb.com> <20190930185855.4115372-3-andriin@fb.com> Organization: Netronome Systems, Ltd. MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Mon, 30 Sep 2019 15:58:35 -0700, Andrii Nakryiko wrote: > On Mon, Sep 30, 2019 at 3:55 PM Song Liu wrote: > > > > On Mon, Sep 30, 2019 at 1:43 PM Andrii Nakryiko wrote: > > > > > > Make bpf_helpers.h and bpf_endian.h official part of libbpf. Ensure they > > > are installed along the other libbpf headers. > > > > > > Signed-off-by: Andrii Nakryiko > > > > Can we merge/rearrange 2/6 and 3/6, so they is a git-rename instead of > > many +++ and ---? > > I arranged them that way because of Github sync. We don't sync > selftests/bpf changes to Github, and it causes more churn if commits > have a mix of libbpf and selftests changes. > > I didn't modify bpf_helpers.h/bpf_endian.h between those patches, so > don't worry about reviewing contents ;) I thought we were over this :/ Please merge the patches.