From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.0 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id DA5F8C35280 for ; Mon, 30 Sep 2019 23:43:43 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 9A05620815 for ; Mon, 30 Sep 2019 23:43:43 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=netronome-com.20150623.gappssmtp.com header.i=@netronome-com.20150623.gappssmtp.com header.b="kC0JrrjE" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1731819AbfI3Xnm (ORCPT ); Mon, 30 Sep 2019 19:43:42 -0400 Received: from mail-qk1-f194.google.com ([209.85.222.194]:41498 "EHLO mail-qk1-f194.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726425AbfI3Xnm (ORCPT ); Mon, 30 Sep 2019 19:43:42 -0400 Received: by mail-qk1-f194.google.com with SMTP id p10so9473755qkg.8 for ; Mon, 30 Sep 2019 16:43:41 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=netronome-com.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:in-reply-to:references :organization:mime-version:content-transfer-encoding; bh=j7FEIc40a5brhUsW65fh97TInIL+5jCJf0kV3TigQR0=; b=kC0JrrjEwXbI64mH4RZ9wwZcD6K7yFZ3+gARn+geJMcVhDOe5OesnGlEh8D4ns8lxL NB2MtZ6J9OZmCNIhKOI6pYxf7RMmLv3qCSxY1PAS3Hk6jhtl0B90A6hR2eplUZ0uZZlo GQTplPo+5kAcdGIsIDnjhvmMT4JU3PThTPCgUfwhHSGoEp+Tw7AKsim9TfkB5yZKDGJc OFVvZUSM/kEFo0VxTf4f9Dh/N3hSGDg6pkcjRv82SQn6wsKp75ZQQR4je05Nck4H7zT0 iAHgWTtdVLZIwcPeH5rcKMMC6LsTqbsWiJq9dfvayDZMXdrwGaZqGqVJtF41vVXaqjNj Dtyg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:in-reply-to :references:organization:mime-version:content-transfer-encoding; bh=j7FEIc40a5brhUsW65fh97TInIL+5jCJf0kV3TigQR0=; b=QNwh+poxiaNFZ0amfaGoz2drqP1E/o1hTNqZw6aygiMIzyz5mv8CNScq+2NXivZh6U YQkbaEbpnyBVztxrRAnDqfxbDi5+2FeXtOUtBb/8aXgNdDmjrBNXFpNYeKHYlye2rGR3 b/mlpeySHc8O+snIjaGaG1NpJCR87QJNsgwO/kAa3Qi9pJ3NkZthsjBhX74UcNkqb+TP SEdKSiq0/Z9jsGuIWgsOPDbpfOL8sA/pJ5jGNCoGD5wgkSOrvrww60lx+g7L6S7CXaFF J4W6+zJEst742w6a+LSSIEbvl7Xbo2gSuyThNbdimHVDXSwS0Tn2WSUoMmorDaFYYsgF huPQ== X-Gm-Message-State: APjAAAWI1tF3V116rHZ3qxbWxrR2FqerkuBFvvCJhDTQGEa348Lb71SL 3ut5k3sHjuXyKl0FWIfl32oFtw== X-Google-Smtp-Source: APXvYqyU2fv7IJAeui4AssjHvmvgGckRbJz/aZom7dPZ046isg7yL1zowFoAdXsJntnz+hEZtu5kQQ== X-Received: by 2002:a37:c204:: with SMTP id i4mr2993539qkm.282.1569887021544; Mon, 30 Sep 2019 16:43:41 -0700 (PDT) Received: from cakuba.netronome.com ([66.60.152.14]) by smtp.gmail.com with ESMTPSA id d69sm6676520qkc.87.2019.09.30.16.43.40 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 30 Sep 2019 16:43:41 -0700 (PDT) Date: Mon, 30 Sep 2019 16:43:37 -0700 From: Jakub Kicinski To: Andrii Nakryiko Cc: Song Liu , Andrii Nakryiko , bpf , Networking , Alexei Starovoitov , Daniel Borkmann , Kernel Team Subject: Re: [PATCH bpf-next 2/6] libbpf: move bpf_helpers.h, bpf_endian.h into libbpf Message-ID: <20190930164337.6d214cdc@cakuba.netronome.com> In-Reply-To: References: <20190930185855.4115372-1-andriin@fb.com> <20190930185855.4115372-3-andriin@fb.com> <20190930161814.381c9bb0@cakuba.netronome.com> Organization: Netronome Systems, Ltd. MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Mon, 30 Sep 2019 16:30:02 -0700, Andrii Nakryiko wrote: > On Mon, Sep 30, 2019 at 4:18 PM Jakub Kicinski wrote: > > On Mon, 30 Sep 2019 15:58:35 -0700, Andrii Nakryiko wrote: > > > On Mon, Sep 30, 2019 at 3:55 PM Song Liu wrote: > > > > > > > > On Mon, Sep 30, 2019 at 1:43 PM Andrii Nakryiko wrote: > > > > > > > > > > Make bpf_helpers.h and bpf_endian.h official part of libbpf. Ensure they > > > > > are installed along the other libbpf headers. > > > > > > > > > > Signed-off-by: Andrii Nakryiko > > > > > > > > Can we merge/rearrange 2/6 and 3/6, so they is a git-rename instead of > > > > many +++ and ---? > > > > > > I arranged them that way because of Github sync. We don't sync > > > selftests/bpf changes to Github, and it causes more churn if commits > > > have a mix of libbpf and selftests changes. > > > > > > I didn't modify bpf_helpers.h/bpf_endian.h between those patches, so > > > don't worry about reviewing contents ;) > > > > I thought we were over this :/ Please merge the patches. > > I'll merge those two patches, our sync script can handle that now, > though with a bit of human input. I'm not exactly sure on the "why" > though Awesome, thank you! > I think generally splitting libbpf changes and selftests > changes is a good thing, no? I'm not sure, here headers are moved to a better location. To me it seems like the logical change is move, rather than add X, remove X.