From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0918BC10F14 for ; Thu, 3 Oct 2019 19:31:28 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id D4BD320862 for ; Thu, 3 Oct 2019 19:31:27 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1731411AbfJCTb1 (ORCPT ); Thu, 3 Oct 2019 15:31:27 -0400 Received: from shards.monkeyblade.net ([23.128.96.9]:47742 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729982AbfJCTb0 (ORCPT ); Thu, 3 Oct 2019 15:31:26 -0400 Received: from localhost (unknown [IPv6:2601:601:9f00:1e2::3d5]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (Client did not present a certificate) (Authenticated sender: davem-davemloft) by shards.monkeyblade.net (Postfix) with ESMTPSA id 1D319146D1AC4; Thu, 3 Oct 2019 12:31:26 -0700 (PDT) Date: Thu, 03 Oct 2019 12:31:25 -0700 (PDT) Message-Id: <20191003.123125.1653429259406233251.davem@davemloft.net> To: edumazet@google.com Cc: netdev@vger.kernel.org, eric.dumazet@gmail.com, jiri@mellanox.com, syzkaller@googlegroups.com Subject: Re: [PATCH net-next] net: propagate errors correctly in register_netdevice() From: David Miller In-Reply-To: <20191003155924.71666-1-edumazet@google.com> References: <20191003155924.71666-1-edumazet@google.com> X-Mailer: Mew version 6.8 on Emacs 26.1 Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Thu, 03 Oct 2019 12:31:26 -0700 (PDT) Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org From: Eric Dumazet Date: Thu, 3 Oct 2019 08:59:24 -0700 > If netdev_name_node_head_alloc() fails to allocate > memory, we absolutely want register_netdevice() to return > -ENOMEM instead of zero :/ > > One of the syzbot report looked like : > > general protection fault: 0000 [#1] PREEMPT SMP KASAN ... > Fixes: ff92741270bf ("net: introduce name_node struct to be used in hashlist") > Signed-off-by: Eric Dumazet > Cc: Jiri Pirko > Reported-by: syzbot Applied.