Re: [PATCH net-next 0/2] mv88e6xxx: Allow config of ATU hash algorithm

[Andrew Lunn <andrew@lunn.ch>]

On Thu, Oct 03, 2019 at 07:14:55PM -0700, Jakub Kicinski wrote:
> On Fri,  4 Oct 2019 03:35:21 +0200, Andrew Lunn wrote:
> > The Marvell switches allow the hash algorithm for MAC addresses in the
> > address translation unit to be configured. Add support to the DSA core
> > to allow DSA drivers to make use of devlink parameters, and allow the
> > ATU hash to be get/set via such a parameter.
> > 
> > Andrew Lunn (2):
> >   net: dsa: Add support for devlink device parameters
> >   net: dsa: mv88e6xxx: Add devlink param for ATU hash algorithm.
> > 
> >  drivers/net/dsa/mv88e6xxx/chip.c        | 136 +++++++++++++++++++++++-
> >  drivers/net/dsa/mv88e6xxx/chip.h        |   4 +
> >  drivers/net/dsa/mv88e6xxx/global1.h     |   3 +
> >  drivers/net/dsa/mv88e6xxx/global1_atu.c |  30 ++++++
> >  include/net/dsa.h                       |  23 ++++
> >  net/dsa/dsa.c                           |  48 +++++++++
> >  net/dsa/dsa2.c                          |   7 +-
> >  7 files changed, 249 insertions(+), 2 deletions(-)
> 
> We try to make sure devlink parameters are documented under
> Documentation/networking/devlink-params-$drv. Could you add 
> a simple doc for mv88e6xxx with a short description?

Jakub

Sure, no problem.

I don't know what the hash algorithms actually are, we have just
played around and found that in some settings, a different value
helps. So the documentation will be limited.

	Andrew