From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.0 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id AADABC47404 for ; Fri, 4 Oct 2019 21:40:48 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 721AB21D81 for ; Fri, 4 Oct 2019 21:40:48 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=lunn.ch header.i=@lunn.ch header.b="ShA53JA2" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2387759AbfJDVkr (ORCPT ); Fri, 4 Oct 2019 17:40:47 -0400 Received: from vps0.lunn.ch ([185.16.172.187]:33452 "EHLO vps0.lunn.ch" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725730AbfJDVkr (ORCPT ); Fri, 4 Oct 2019 17:40:47 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lunn.ch; s=20171124; h=In-Reply-To:Content-Type:MIME-Version:References:Message-ID: Subject:Cc:To:From:Date:Sender:Reply-To:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=M1M/k4IIrk8kGVxwaFpXU6gJ63/1aMhsMG9wmmFpQCM=; b=ShA53JA2YU9PAiTDmFW2K8QMxC tATuqk5S7gBam71oaDp7+MIhK7QgR9K+2HxPr5GajbdEyCsDaTz4sJsBpM2X3WIE48U6yEQp1xibx OMYbsoX5mLu/QzEIInyGIgIEK+HVgZ0ag4OHpziTNE+FO92YyqJXkwQwKfKA6uI6pt2Q=; Received: from andrew by vps0.lunn.ch with local (Exim 4.92.2) (envelope-from ) id 1iGVJb-0003WF-Oy; Fri, 04 Oct 2019 23:40:43 +0200 Date: Fri, 4 Oct 2019 23:40:43 +0200 From: Andrew Lunn To: Jakub Kicinski Cc: David Miller , netdev , Vivien Didelot , Florian Fainelli Subject: Re: [PATCH v2 net-next 2/2] net: dsa: mv88e6xxx: Add devlink param for ATU hash algorithm. Message-ID: <20191004214043.GB12889@lunn.ch> References: <20191004210934.12813-1-andrew@lunn.ch> <20191004210934.12813-3-andrew@lunn.ch> <20191004143236.334e9e05@cakuba.hsd1.ca.comcast.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20191004143236.334e9e05@cakuba.hsd1.ca.comcast.net> User-Agent: Mutt/1.10.1 (2018-07-13) Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Fri, Oct 04, 2019 at 02:32:36PM -0700, Jakub Kicinski wrote: > On Fri, 4 Oct 2019 23:09:34 +0200, Andrew Lunn wrote: > > diff --git a/Documentation/networking/devlink-params-mv88e6xxx.txt b/Documentation/networking/devlink-params-mv88e6xxx.txt > > new file mode 100644 > > index 000000000000..cc5c1ac87c36 > > --- /dev/null > > +++ b/Documentation/networking/devlink-params-mv88e6xxx.txt > > @@ -0,0 +1,6 @@ > > +ATU_hash [DEVICE, DRIVER-SPECIFIC] > > + Select one of four possible hashing algorithms for > > + MAC addresses in the Address Translation Unity. > > + A value of 3 seems to work better than the default of > > + 1 when many MAC addresses have the same OUI. > > + Configuration mode: runtime > > I think it's common practice to specify the type here? Otherwise looks > good to me, thanks for adding it! Hi Jakub Ah, yes. It is a u8, but only values 0-3 are valid. I will do a v3, but will wait a day for further comments. Andrew