netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Eric Biggers <ebiggers@kernel.org>
To: netdev@vger.kernel.org
Subject: [PATCH net 0/4] llc: fix sk_buff refcounting
Date: Sun,  6 Oct 2019 14:24:23 -0700	[thread overview]
Message-ID: <20191006212427.427682-1-ebiggers@kernel.org> (raw)

Hello,

Patches 1-2 fix the memory leaks that syzbot has reported in net/llc:

	memory leak in llc_ui_create (2)
	memory leak in llc_ui_sendmsg
	memory leak in llc_conn_ac_send_sabme_cmd_p_set_x

Patches 3-4 fix related bugs that I noticed while reading this code.

Note: I've tested that this fixes the syzbot bugs, but otherwise I don't
know of any way to test this code.

Eric Biggers (4):
  llc: fix sk_buff leak in llc_sap_state_process()
  llc: fix sk_buff leak in llc_conn_service()
  llc: fix another potential sk_buff leak in llc_ui_sendmsg()
  llc: fix sk_buff refcounting in llc_conn_state_process()

 include/net/llc_conn.h |  2 +-
 net/llc/af_llc.c       | 34 ++++++++++++---------
 net/llc/llc_c_ac.c     |  8 +++--
 net/llc/llc_conn.c     | 67 +++++++++++-------------------------------
 net/llc/llc_if.c       | 12 +++++---
 net/llc/llc_s_ac.c     | 12 ++++++--
 net/llc/llc_sap.c      | 23 +++++----------
 7 files changed, 69 insertions(+), 89 deletions(-)

-- 
2.23.0


             reply	other threads:[~2019-10-06 21:29 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-10-06 21:24 Eric Biggers [this message]
2019-10-06 21:24 ` [PATCH net 1/4] llc: fix sk_buff leak in llc_sap_state_process() Eric Biggers
2019-10-06 21:24 ` [PATCH net 2/4] llc: fix sk_buff leak in llc_conn_service() Eric Biggers
2019-10-06 21:24 ` [PATCH net 3/4] llc: fix another potential sk_buff leak in llc_ui_sendmsg() Eric Biggers
2019-10-06 21:24 ` [PATCH net 4/4] llc: fix sk_buff refcounting in llc_conn_state_process() Eric Biggers
2019-10-08 21:15 ` [PATCH net 0/4] llc: fix sk_buff refcounting Jakub Kicinski

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20191006212427.427682-1-ebiggers@kernel.org \
    --to=ebiggers@kernel.org \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).