From: Jakub Kicinski <jakub.kicinski@netronome.com>
To: Vinicius Costa Gomes <vinicius.gomes@intel.com>
Cc: netdev@vger.kernel.org, jhs@mojatatu.com,
xiyou.wangcong@gmail.com, jiri@resnulli.us, davem@davemloft.net,
olteanv@gmail.com
Subject: Re: [PATCH net v1] net: taprio: Fix returning EINVAL when configuring without flags
Date: Wed, 9 Oct 2019 18:52:53 -0700 [thread overview]
Message-ID: <20191009185253.151636e1@cakuba.netronome.com> (raw)
In-Reply-To: <20191008232007.16083-1-vinicius.gomes@intel.com>
On Tue, 8 Oct 2019 16:20:07 -0700, Vinicius Costa Gomes wrote:
> When configuring a taprio instance if "flags" is not specified (or
> it's zero), taprio currently replies with an "Invalid argument" error.
>
> So, set the return value to zero after we are done with all the
> checks.
>
> Fixes: 9c66d1564676 ("taprio: Add support for hardware offloading")
> Signed-off-by: Vinicius Costa Gomes <vinicius.gomes@intel.com>
Applied, thanks.
prev parent reply other threads:[~2019-10-10 1:53 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-08 23:20 [PATCH net v1] net: taprio: Fix returning EINVAL when configuring without flags Vinicius Costa Gomes
2019-10-08 23:58 ` Vladimir Oltean
2019-10-09 0:11 ` Vladimir Oltean
2019-10-09 0:22 ` Vinicius Costa Gomes
2019-10-10 1:52 ` Jakub Kicinski [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191009185253.151636e1@cakuba.netronome.com \
--to=jakub.kicinski@netronome.com \
--cc=davem@davemloft.net \
--cc=jhs@mojatatu.com \
--cc=jiri@resnulli.us \
--cc=netdev@vger.kernel.org \
--cc=olteanv@gmail.com \
--cc=vinicius.gomes@intel.com \
--cc=xiyou.wangcong@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).