* [PATCH net] Documentation: net: fix path to devlink-trap-netdevsim
@ 2019-10-09 19:06 Jakub Kicinski
2019-10-09 19:34 ` Ido Schimmel
0 siblings, 1 reply; 3+ messages in thread
From: Jakub Kicinski @ 2019-10-09 19:06 UTC (permalink / raw)
To: davem; +Cc: netdev, oss-drivers, idosch, jiri, Jakub Kicinski, Simon Horman
make htmldocs complains:
Documentation/networking/devlink-trap.rst:175: WARNING: unknown document: /devlink-trap-netdevsim
make the path relative.
Fixes: 9e0874570488 ("Documentation: Add description of netdevsim traps")
Signed-off-by: Jakub Kicinski <jakub.kicinski@netronome.com>
Reviewed-by: Simon Horman <simon.horman@netronome.com>
---
Documentation/networking/devlink-trap.rst | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/Documentation/networking/devlink-trap.rst b/Documentation/networking/devlink-trap.rst
index 8e90a85f3bd5..70335c3ed3c3 100644
--- a/Documentation/networking/devlink-trap.rst
+++ b/Documentation/networking/devlink-trap.rst
@@ -172,7 +172,7 @@ help debug packet drops caused by these exceptions. The following list includes
links to the description of driver-specific traps registered by various device
drivers:
- * :doc:`/devlink-trap-netdevsim`
+ * :doc:`./devlink-trap-netdevsim`
Generic Packet Trap Groups
==========================
--
2.23.0
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH net] Documentation: net: fix path to devlink-trap-netdevsim
2019-10-09 19:06 [PATCH net] Documentation: net: fix path to devlink-trap-netdevsim Jakub Kicinski
@ 2019-10-09 19:34 ` Ido Schimmel
2019-10-09 21:53 ` Jakub Kicinski
0 siblings, 1 reply; 3+ messages in thread
From: Ido Schimmel @ 2019-10-09 19:34 UTC (permalink / raw)
To: Jakub Kicinski; +Cc: davem, netdev, oss-drivers, idosch, jiri, Simon Horman
On Wed, Oct 09, 2019 at 12:06:21PM -0700, Jakub Kicinski wrote:
> make htmldocs complains:
> Documentation/networking/devlink-trap.rst:175: WARNING: unknown document: /devlink-trap-netdevsim
>
> make the path relative.
>
> Fixes: 9e0874570488 ("Documentation: Add description of netdevsim traps")
> Signed-off-by: Jakub Kicinski <jakub.kicinski@netronome.com>
> Reviewed-by: Simon Horman <simon.horman@netronome.com>
Reviewed-by: Ido Schimmel <idosch@mellanox.com>
Thanks for fixing Jakub.
FWIW, someone already sent a patch [1] for this, but now I see that it's
marked as "Not Applicable". Maybe the expectation was that it would go
via the documentation tree? I just checked and I don't see it there [2].
[1] https://patchwork.ozlabs.org/patch/1171361/
[2] git://git.lwn.net/linux.git
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH net] Documentation: net: fix path to devlink-trap-netdevsim
2019-10-09 19:34 ` Ido Schimmel
@ 2019-10-09 21:53 ` Jakub Kicinski
0 siblings, 0 replies; 3+ messages in thread
From: Jakub Kicinski @ 2019-10-09 21:53 UTC (permalink / raw)
To: Ido Schimmel; +Cc: davem, netdev, oss-drivers, idosch, jiri, Simon Horman
On Wed, 9 Oct 2019 22:34:13 +0300, Ido Schimmel wrote:
> On Wed, Oct 09, 2019 at 12:06:21PM -0700, Jakub Kicinski wrote:
> > make htmldocs complains:
> > Documentation/networking/devlink-trap.rst:175: WARNING: unknown document: /devlink-trap-netdevsim
> >
> > make the path relative.
> >
> > Fixes: 9e0874570488 ("Documentation: Add description of netdevsim traps")
> > Signed-off-by: Jakub Kicinski <jakub.kicinski@netronome.com>
> > Reviewed-by: Simon Horman <simon.horman@netronome.com>
>
> Reviewed-by: Ido Schimmel <idosch@mellanox.com>
>
> Thanks for fixing Jakub.
>
> FWIW, someone already sent a patch [1] for this, but now I see that it's
> marked as "Not Applicable". Maybe the expectation was that it would go
> via the documentation tree? I just checked and I don't see it there [2].
>
> [1] https://patchwork.ozlabs.org/patch/1171361/
> [2] git://git.lwn.net/linux.git
Ah, thanks for pointing that out! Looks like some of Jonathan are going
via doc tree :S
I'll just apply that one then.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2019-10-09 21:54 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2019-10-09 19:06 [PATCH net] Documentation: net: fix path to devlink-trap-netdevsim Jakub Kicinski
2019-10-09 19:34 ` Ido Schimmel
2019-10-09 21:53 ` Jakub Kicinski
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).