netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH next] ipvlan: consolidate TSO flags using NETIF_F_ALL_TSO
@ 2019-10-09 23:20 Mahesh Bandewar
  2019-10-11  1:05 ` Jakub Kicinski
  0 siblings, 1 reply; 2+ messages in thread
From: Mahesh Bandewar @ 2019-10-09 23:20 UTC (permalink / raw)
  To: Netdev; +Cc: Eric Dumazet, David Miller, Mahesh Bandewar, Mahesh Bandewar

This will ensure that any new TSO related flags added (which
would be part of ALL_TSO mask and IPvlan driver doesn't need
to update every time new flag gets added.

Signed-off-by: Mahesh Bandewar <maheshb@google.com>
Suggested-by: Eric Dumazet <edumazet@google.com>
---
 drivers/net/ipvlan/ipvlan_main.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/net/ipvlan/ipvlan_main.c b/drivers/net/ipvlan/ipvlan_main.c
index 887bbba4631e..b0ac557f8e60 100644
--- a/drivers/net/ipvlan/ipvlan_main.c
+++ b/drivers/net/ipvlan/ipvlan_main.c
@@ -108,8 +108,8 @@ static void ipvlan_port_destroy(struct net_device *dev)
 
 #define IPVLAN_FEATURES \
 	(NETIF_F_SG | NETIF_F_CSUM_MASK | NETIF_F_HIGHDMA | NETIF_F_FRAGLIST | \
-	 NETIF_F_GSO | NETIF_F_TSO | NETIF_F_GSO_ROBUST | \
-	 NETIF_F_TSO_ECN | NETIF_F_TSO6 | NETIF_F_GRO | NETIF_F_RXCSUM | \
+	 NETIF_F_GSO | NETIF_F_ALL_TSO | NETIF_F_GSO_ROBUST | \
+	 NETIF_F_GRO | NETIF_F_RXCSUM | \
 	 NETIF_F_HW_VLAN_CTAG_FILTER | NETIF_F_HW_VLAN_STAG_FILTER)
 
 #define IPVLAN_STATE_MASK \
-- 
2.23.0.581.g78d2f28ef7-goog


^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH next] ipvlan: consolidate TSO flags using NETIF_F_ALL_TSO
  2019-10-09 23:20 [PATCH next] ipvlan: consolidate TSO flags using NETIF_F_ALL_TSO Mahesh Bandewar
@ 2019-10-11  1:05 ` Jakub Kicinski
  0 siblings, 0 replies; 2+ messages in thread
From: Jakub Kicinski @ 2019-10-11  1:05 UTC (permalink / raw)
  To: Mahesh Bandewar; +Cc: Netdev, Eric Dumazet, David Miller, Mahesh Bandewar

On Wed,  9 Oct 2019 16:20:11 -0700, Mahesh Bandewar wrote:
> This will ensure that any new TSO related flags added (which
> would be part of ALL_TSO mask and IPvlan driver doesn't need
> to update every time new flag gets added.
> 
> Signed-off-by: Mahesh Bandewar <maheshb@google.com>
> Suggested-by: Eric Dumazet <edumazet@google.com>

Applied, thanks!

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2019-10-11  1:06 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2019-10-09 23:20 [PATCH next] ipvlan: consolidate TSO flags using NETIF_F_ALL_TSO Mahesh Bandewar
2019-10-11  1:05 ` Jakub Kicinski

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).