From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.9 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D5407C47404 for ; Fri, 11 Oct 2019 22:08:02 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 9DAB021D71 for ; Fri, 11 Oct 2019 22:08:02 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b="AUmbSlE2" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729356AbfJKWIC (ORCPT ); Fri, 11 Oct 2019 18:08:02 -0400 Received: from mail-pg1-f194.google.com ([209.85.215.194]:38831 "EHLO mail-pg1-f194.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729269AbfJKWIB (ORCPT ); Fri, 11 Oct 2019 18:08:01 -0400 Received: by mail-pg1-f194.google.com with SMTP id x10so6541810pgi.5 for ; Fri, 11 Oct 2019 15:08:01 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=u657WMybRKGf4iTEdbvgPKUQHMvQCoMqXMiRc7mnyNw=; b=AUmbSlE2jrKfmGq51Nnu0DTKILtSqFr/lgvJE3gHd/UhnFDMR4LvhUquwiYY4yI1UG GQjwC95tlThgfHSDmX5isdgd8rfRVIVuXg8LM5+EKX3RU75Tm86erjWm8b7IPX1aL+fQ PhW9UWXV+kPuuyJxGmEnU4tHZfDaLYbNp5Gws= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=u657WMybRKGf4iTEdbvgPKUQHMvQCoMqXMiRc7mnyNw=; b=JdQrYQNKt1qHrqfyh+0uOqgSF3l+iW2siefX98+1oIxxC0ouw85781zBxbe+wOiSsD tRVJAxdOj+emMVU+9tGcoKo47IBb1U0pnujWIq4poSzl9GTOAZKZ3Odq/OvGPbgze3Ut Xwz5eDkvgKuuaI4UMNUBDqtnl1vKwjVvDRscPe481o0fbuKj95posd71I0k0fKfXyi5B PBO2RzngETqEAWZ8/xgi9gs3BKUCxqW7z/wQ0xxxCeM9mCi/veOjMabhFM97/8qVAy0O nDlwpkuriyBhrPMllQzFpL/PTS7gyYeUAZiqZE4RecOn3VM/X7aZy7rs/mDdC+178xTm 7zwg== X-Gm-Message-State: APjAAAXhFPv7C10p5U9l4FzxNF4Xe4+Ia5eWwBmrfc5y3aNLfqeb+t+J klHTad58ZrHynGm9T80CNXMOzQ== X-Google-Smtp-Source: APXvYqwXd6PES+m6U0qYX3W5eqwpAP4ETGleW9x3CN4Ko02h7XpIW9CP+aqFM6d6plqqgwrB+0MgxQ== X-Received: by 2002:aa7:956a:: with SMTP id x10mr18500783pfq.220.1570831680868; Fri, 11 Oct 2019 15:08:00 -0700 (PDT) Received: from www.outflux.net (smtp.outflux.net. [198.145.64.163]) by smtp.gmail.com with ESMTPSA id p66sm10301368pfg.127.2019.10.11.15.07.59 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 11 Oct 2019 15:07:59 -0700 (PDT) Date: Fri, 11 Oct 2019 15:07:58 -0700 From: Kees Cook To: Miguel Ojeda Cc: Linus Torvalds , Joe Perches , linux-sctp@vger.kernel.org, Borislav Petkov , "H . Peter Anvin" , Thomas Gleixner , Pavel Machek , "Gustavo A . R . Silva" , Arnaldo Carvalho de Melo , Kan Liang , Namhyung Kim , Jiri Olsa , Alexander Shishkin , Shawn Landden , the arch/x86 maintainers , Linux Kernel Mailing List , Nathan Chancellor , Nick Desaulniers , Andrew Morton , David Miller , clang-built-linux , Jonathan Corbet , Vlad Yasevich , Neil Horman , Marcelo Ricardo Leitner , "open list:DOCUMENTATION" , Netdev Subject: Re: [PATCH 0/4] treewide: Add 'fallthrough' pseudo-keyword Message-ID: <201910111506.45AE850D5@keescook> References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Fri, Oct 11, 2019 at 08:01:42PM +0200, Miguel Ojeda wrote: > Hi Linus, > > On Fri, Oct 11, 2019 at 6:30 PM Linus Torvalds > wrote: > > > > On Sat, Oct 5, 2019 at 9:46 AM Joe Perches wrote: > > > > > > Add 'fallthrough' pseudo-keyword to enable the removal of comments > > > like '/* fallthrough */'. > > > > I applied patches 1-3 to my tree just to make it easier for people to > > start doing this. Maybe some people want to do the conversion on their > > own subsystem rather than with a global script, but even if not, this > > looks better as a "prepare for the future" series and I feel that if > > we're doing the "fallthrough" thing eventually, the sooner we do the > > prepwork the better. > > > > I'm a tiny bit worried that the actual conversion is just going to > > cause lots of pain for the stable people, but I'll not worry about it > > _too_ much. If the stable people decide that it's too painful for them > > to deal with the comment vs keyword model, they may want to backport > > these three patches too. > > I was waiting for a v2 series to pick it up given we had some pending changes... Hmpf, looks like it's in torvalds/master now. Miguel, most of the changes were related to the commit log, IIRC, so that ship has sailed. :( Can the stuff in Documentation/ be improved with a follow-up patch, perhaps? -- Kees Cook