From: Richard Cochran <richardcochran@gmail.com>
To: "Keller, Jacob E" <jacob.e.keller@intel.com>
Cc: "netdev@vger.kernel.org" <netdev@vger.kernel.org>,
Intel Wired LAN <intel-wired-lan@lists.osuosl.org>,
"Kirsher, Jeffrey T" <jeffrey.t.kirsher@intel.com>,
Brandon Streiff <brandon.streiff@ni.com>
Subject: Re: [net-next v3 3/7] mv88e6xxx: reject unsupported external timestamp flags
Date: Sat, 12 Oct 2019 16:27:19 -0700 [thread overview]
Message-ID: <20191012232719.GA7148@localhost> (raw)
In-Reply-To: <02874ECE860811409154E81DA85FBB5896926B0B@ORSMSX121.amr.corp.intel.com>
On Sat, Oct 12, 2019 at 07:36:31PM +0000, Keller, Jacob E wrote:
> Right, so in practice, unless it supports both edges, it should reject setting both RISING and FALLING together.
Enforcing that now *could* break existing user space, but I wonder
whether any programs would actually be affected.
Maybe we can add a STRICT flag than requests strict checking. If user
space uses the "2" ioctl, then we would add this flag before invoking
the driver callback.
Thanks,
Richard
next prev parent reply other threads:[~2019-10-12 23:27 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-09-26 18:11 [net-next v3 0/7] new PTP ioctl fixes Jacob Keller
2019-09-26 18:11 ` [net-next v3 1/7] ptp: correctly disable flags on old ioctls Jacob Keller
2019-10-11 1:03 ` Brown, Aaron F
2019-09-26 18:11 ` [net-next v3 2/7] net: reject PTP periodic output requests with unsupported flags Jacob Keller
2019-10-11 1:05 ` Brown, Aaron F
2019-10-12 18:08 ` Richard Cochran
2019-09-26 18:11 ` [net-next v3 3/7] mv88e6xxx: reject unsupported external timestamp flags Jacob Keller
2019-10-12 18:24 ` Richard Cochran
2019-10-12 19:36 ` Keller, Jacob E
2019-10-12 23:27 ` Richard Cochran [this message]
2019-10-14 17:20 ` Keller, Jacob E
2019-09-26 18:11 ` [net-next v3 4/7] dp83640: " Jacob Keller
2019-10-12 18:28 ` Richard Cochran
2019-09-26 18:11 ` [net-next v3 5/7] igb: " Jacob Keller
2019-10-11 0:57 ` [Intel-wired-lan] " Brown, Aaron F
2019-10-12 18:31 ` Richard Cochran
2019-09-26 18:11 ` [net-next v3 6/7] mlx5: " Jacob Keller
2019-10-12 18:36 ` Richard Cochran
2019-09-26 18:11 ` [net-next v3 7/7] renesas: " Jacob Keller
2019-09-27 16:22 ` Sergei Shtylyov
2019-10-12 18:38 ` Richard Cochran
2019-09-27 18:29 ` [net-next v3 0/7] new PTP ioctl fixes David Miller
2019-09-27 22:16 ` Keller, Jacob E
2019-11-13 1:58 ` Richard Cochran
2019-11-13 17:10 ` Richard Cochran
2019-11-13 19:34 ` Richard Cochran
2019-11-13 19:58 ` Keller, Jacob E
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191012232719.GA7148@localhost \
--to=richardcochran@gmail.com \
--cc=brandon.streiff@ni.com \
--cc=intel-wired-lan@lists.osuosl.org \
--cc=jacob.e.keller@intel.com \
--cc=jeffrey.t.kirsher@intel.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).