From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.0 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0CF88ECE587 for ; Mon, 14 Oct 2019 13:00:31 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id DA4B7222BD for ; Mon, 14 Oct 2019 13:00:30 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=lunn.ch header.i=@lunn.ch header.b="tlEaobsc" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1732008AbfJNNA2 (ORCPT ); Mon, 14 Oct 2019 09:00:28 -0400 Received: from vps0.lunn.ch ([185.16.172.187]:44674 "EHLO vps0.lunn.ch" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1730087AbfJNNA2 (ORCPT ); Mon, 14 Oct 2019 09:00:28 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lunn.ch; s=20171124; h=In-Reply-To:Content-Type:MIME-Version:References:Message-ID: Subject:Cc:To:From:Date:Sender:Reply-To:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=XGkEijKN8/OOyckGnnk5bIOpQGRjn9DO52eDP6zmWJU=; b=tlEaobscxjg3RnSmShWjaY5E5m 01PkwYpOpUS7j+G5/lWUEug4IOWcAX9GfwcFk9+4bCz2faJjjFZ6A0hZ5qInVBDZ+bPmudovemDty nKb0T3lVy9ZgjSOMJpFlFX+EFc01ier2/whiiDkGXxv573rH4USe0UTJoWcNeliMsvwU=; Received: from andrew by vps0.lunn.ch with local (Exim 4.92.2) (envelope-from ) id 1iJzxQ-0005Ln-O4; Mon, 14 Oct 2019 15:00:16 +0200 Date: Mon, 14 Oct 2019 15:00:16 +0200 From: Andrew Lunn To: Vladimir Oltean Cc: Nishad Kamdar , Vivien Didelot , Florian Fainelli , "David S. Miller" , Greg Kroah-Hartman , Joe Perches , Uwe =?iso-8859-1?Q?Kleine-K=F6nig?= , netdev , lkml Subject: Re: [PATCH] net: dsa: sja1105: Use the correct style for SPDX License Identifier Message-ID: <20191014130016.GD19861@lunn.ch> References: <20191012123938.GA6865@nishad> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.10.1 (2018-07-13) Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Mon, Oct 14, 2019 at 01:46:26PM +0300, Vladimir Oltean wrote: > Hi Nishad, > > On Sat, 12 Oct 2019 at 15:39, Nishad Kamdar wrote: > > > > This patch corrects the SPDX License Identifier style > > in header files related to Distributed Switch Architecture > > drivers for NXP SJA1105 series Ethernet switch support. > > For C header files Documentation/process/license-rules.rst > > mandates C-like comments (opposed to C source files where > > C++ style should be used) > > > > Changes made by using a script provided by Joe Perches here: > > https://lkml.org/lkml/2019/2/7/46. > > > > Suggested-by: Joe Perches > > Signed-off-by: Nishad Kamdar > > --- > > Your commit message has nothing to do with what you're fixing, but > whatever. The SPDX identifiers _are_ using C-like comments. Agreed. Please fix the commit message, and maybe make the script generating the commit message, so future uses of it will get the message correct. Thanks Andrew