From: David Miller <davem@davemloft.net>
To: vcaputo@pengaru.com
Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] net: core: datagram: tidy up copy functions a bit
Date: Tue, 15 Oct 2019 14:59:11 -0700 (PDT) [thread overview]
Message-ID: <20191015.145911.716932933579995114.davem@davemloft.net> (raw)
In-Reply-To: <20191012115509.jrqe43yozs7kknv5@shells.gnugeneration.com>
From: Vito Caputo <vcaputo@pengaru.com>
Date: Sat, 12 Oct 2019 04:55:09 -0700
> + if ((copy = min(start - offset, len)) > 0) {
As Eric said, we try to avoid this very construct these days.
I'm not applying this patch.
Thank you.
next prev parent reply other threads:[~2019-10-15 21:59 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-12 11:55 [PATCH] net: core: datagram: tidy up copy functions a bit Vito Caputo
2019-10-13 19:30 ` Eric Dumazet
2019-10-13 20:01 ` Vito Caputo
2019-10-13 20:17 ` Eric Dumazet
2019-10-13 22:41 ` Vito Caputo
2019-10-14 1:04 ` Eric Dumazet
2019-10-15 21:59 ` David Miller [this message]
2019-10-21 8:53 ` [net] 635f03c839: WARNING:at_net/core/datagram.c:#__skb_datagram_iter kernel test robot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191015.145911.716932933579995114.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=vcaputo@pengaru.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).