From: David Miller <davem@davemloft.net>
To: edumazet@google.com
Cc: netdev@vger.kernel.org, eric.dumazet@gmail.com,
jakub.kicinski@netronome.com, syzkaller@googlegroups.com
Subject: Re: [PATCH net] tcp: fix a possible lockdep splat in tcp_done()
Date: Tue, 15 Oct 2019 20:15:29 -0700 (PDT) [thread overview]
Message-ID: <20191015.201529.1895543949965274139.davem@davemloft.net> (raw)
In-Reply-To: <20191014134757.185995-1-edumazet@google.com>
From: Eric Dumazet <edumazet@google.com>
Date: Mon, 14 Oct 2019 06:47:57 -0700
> syzbot found that if __inet_inherit_port() returns an error,
> we call tcp_done() after inet_csk_prepare_forced_close(),
> meaning the socket lock is no longer held.
>
> We might fix this in a different way in net-next, but
> for 5.4 it seems safer to relax the lockdep check.
>
> Fixes: d983ea6f16b8 ("tcp: add rcu protection around tp->fastopen_rsk")
> Signed-off-by: Eric Dumazet <edumazet@google.com>
> Reported-by: syzbot <syzkaller@googlegroups.com>
Applied.
prev parent reply other threads:[~2019-10-16 3:15 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-14 13:47 [PATCH net] tcp: fix a possible lockdep splat in tcp_done() Eric Dumazet
2019-10-16 3:15 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191015.201529.1895543949965274139.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=eric.dumazet@gmail.com \
--cc=jakub.kicinski@netronome.com \
--cc=netdev@vger.kernel.org \
--cc=syzkaller@googlegroups.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).